From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: ehci: Fix test mode for connected ports
Date: Fri, 27 Sep 2013 16:36:27 +0200 [thread overview]
Message-ID: <201309271636.27952.marex@denx.de> (raw)
In-Reply-To: <1380045187-7320-1-git-send-email-jwerner@chromium.org>
Dear Julius Werner,
> The EHCI controller has some very specific requirements for the USB 2.0
> port test modes, which were not closely followed in the initial test
> mode commit. It demands that the host controller is completely shut down
> (all ports suspended, Run/Stop bit unset) when activating test mode, and
> will not work on an already enumerated port.
>
> This patch fixes that by introducing a new ehci_shutdown() function that
> closely follows the procedure listed in EHCI 4.14. Also, when we have
> such a function anyway, we might as well also use it in
> usb_lowlevel_stop() to make the normal host controller shutdown cleaner.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
Applied, thanks
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-09-27 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 0:29 [U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports Julius Werner
2013-09-18 2:13 ` Simon Glass
2013-09-18 14:44 ` Marek Vasut
2013-09-18 17:16 ` Julius Werner
2013-09-19 21:48 ` Marek Vasut
2013-09-20 1:39 ` Julius Werner
2013-09-20 5:12 ` Simon Glass
2013-09-24 2:55 ` Julius Werner
2013-09-24 4:06 ` Simon Glass
2013-09-24 6:59 ` Marek Vasut
2013-09-24 17:53 ` [U-Boot] [PATCH v2] " Julius Werner
2013-09-26 23:30 ` Simon Glass
2013-09-27 14:36 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309271636.27952.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.