From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
Bjorn Helgaas <bhelgaas@google.com>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch guide for newbies
Date: Tue, 24 Sep 2013 19:59:58 +0000 [thread overview]
Message-ID: <20130924195958.GO6247@mwanda> (raw)
In-Reply-To: <CA+MoWDpnNjeEN+Crzh2kQ7DPJ_DqEOP4z-9n3=EqP7hiPgZRXg@mail.gmail.com>
On Tue, Sep 24, 2013 at 09:29:49PM +0200, Peter Senna Tschudin wrote:
> I was about to disagree because I've never seen variables named a, b
> or c, but I found that there are at least 2238 variables named a, b or
> c in linux-next. This is not good.
>
In XGIfb_mode_rate_to_ddata() we have:
int B, C, D, F, temp, j;
The A and E variables were removed when the code was refactored. ;P
Places like this are fairly rare in the kernel outside of the staging/
directory.
There are lots of times where a single letter variable name is very
natural.
char c;
C is terse. This is explained in Documentation/CodingStyle.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
Bjorn Helgaas <bhelgaas@google.com>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch guide for newbies
Date: Tue, 24 Sep 2013 22:59:58 +0300 [thread overview]
Message-ID: <20130924195958.GO6247@mwanda> (raw)
In-Reply-To: <CA+MoWDpnNjeEN+Crzh2kQ7DPJ_DqEOP4z-9n3=EqP7hiPgZRXg@mail.gmail.com>
On Tue, Sep 24, 2013 at 09:29:49PM +0200, Peter Senna Tschudin wrote:
> I was about to disagree because I've never seen variables named a, b
> or c, but I found that there are at least 2238 variables named a, b or
> c in linux-next. This is not good.
>
In XGIfb_mode_rate_to_ddata() we have:
int B, C, D, F, temp, j;
The A and E variables were removed when the code was refactored. ;P
Places like this are fairly rare in the kernel outside of the staging/
directory.
There are lots of times where a single letter variable name is very
natural.
char c;
C is terse. This is explained in Documentation/CodingStyle.
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-24 19:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 9:01 checkpatch guide for newbies Dan Carpenter
2013-09-23 9:01 ` Dan Carpenter
2013-09-23 12:46 ` Peter Senna Tschudin
2013-09-23 12:46 ` Peter Senna Tschudin
2013-09-23 13:29 ` Dan Carpenter
2013-09-23 13:29 ` Dan Carpenter
2013-09-23 14:04 ` Geert Uytterhoeven
2013-09-23 14:04 ` Geert Uytterhoeven
2013-09-23 18:06 ` Joe Perches
2013-09-23 18:06 ` Joe Perches
2013-09-23 20:17 ` Joe Perches
2013-09-23 20:17 ` Joe Perches
2013-09-23 18:35 ` bojan prtvar
2013-09-23 18:35 ` bojan prtvar
2013-09-24 16:36 ` Bjorn Helgaas
2013-09-24 16:36 ` Bjorn Helgaas
2013-09-24 17:26 ` Alexander Holler
2013-09-24 17:26 ` Alexander Holler
2013-09-24 17:43 ` Alexander Holler
2013-09-24 17:43 ` Alexander Holler
2013-09-24 18:50 ` Alexander Holler
2013-09-24 18:50 ` Alexander Holler
2013-09-24 19:29 ` Peter Senna Tschudin
2013-09-24 19:29 ` Peter Senna Tschudin
2013-09-24 19:59 ` Dan Carpenter [this message]
2013-09-24 19:59 ` Dan Carpenter
2013-09-24 20:13 ` Bjorn Helgaas
2013-09-24 20:13 ` Bjorn Helgaas
2013-09-24 22:10 ` Alexander Holler
2013-09-24 22:10 ` Alexander Holler
2013-09-26 2:11 ` Al Viro
2013-09-26 2:11 ` Al Viro
2013-09-26 2:52 ` Alexander Holler
2013-09-26 2:52 ` Alexander Holler
2013-09-26 2:57 ` Alexander Holler
2013-09-26 2:57 ` Alexander Holler
2013-09-26 3:04 ` Al Viro
2013-09-26 3:04 ` Al Viro
2013-09-26 3:27 ` Alexander Holler
2013-09-26 3:27 ` Alexander Holler
2013-09-26 3:48 ` Al Viro
2013-09-26 3:48 ` Al Viro
2013-09-26 4:21 ` Alexander Holler
2013-09-26 4:21 ` Alexander Holler
2013-09-26 5:53 ` Julia Lawall
2013-09-26 5:53 ` Julia Lawall
2013-09-26 9:55 ` Alexander Holler
2013-09-26 9:55 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924195958.GO6247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bhelgaas@google.com \
--cc=holler@ahsoftware.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.