All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, acme@ghostprotocols.net, mingo@redhat.com
Subject: Re: [PATCH] perf: fix two warning in bench/numa
Date: Wed, 25 Sep 2013 13:26:29 +0200	[thread overview]
Message-ID: <20130925112629.GB29884@gmail.com> (raw)
In-Reply-To: <20130925073515.GA7053@weiyang.vnet.ibm.com>


* Wei Yang <weiyang@linux.vnet.ibm.com> wrote:

> Hi, all
> 
> Any comments on this one? 
> 
> These two warnings will break the compile of perf under 32-bit machine.

fix looks good to me.

> >-			if (diff.tv_sec >= g->p.nr_secs) {
> >+			if (diff.tv_sec >= (time_t)g->p.nr_secs) {

> >-				printf(" #%2d / %2d: %14.2lf nsecs/op [val: %016lx]\n",
> >+				printf(" #%2d / %2d: %14.2lf nsecs/op [val: %016"PRIu64"]\n",

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  reply	other threads:[~2013-09-25 11:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-22  8:49 [PATCH] perf: fix two warning in bench/numa Wei Yang
2013-09-25  7:35 ` Wei Yang
2013-09-25 11:26   ` Ingo Molnar [this message]
2013-09-26  1:16     ` Wei Yang
2013-10-30  3:18 ` Wei Yang
2013-11-04  6:54 ` [tip:perf/core] perf bench: Fix two warnings tip-bot for Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130925112629.GB29884@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=weiyang@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.