From: "Jürgen Beisert" <jbe@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: ARM/Samsung/S3C24xx: Linux-3.11 crashes when using PWM
Date: Wed, 25 Sep 2013 11:40:36 +0200 [thread overview]
Message-ID: <201309251140.36582.jbe@pengutronix.de> (raw)
In-Reply-To: <5242AA7C.4010905@samsung.com>
Hi Sylwester,
On Wednesday 25 September 2013 11:18:52 Sylwester Nawrocki wrote:
> On 25/09/13 10:29, Jürgen Beisert wrote:
> > Change one single line:
> >
> > diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c
> > b/arch/arm/mach-s3c24xx/mach-mini2440.c index a83db46..d8273da 100644
> > --- a/arch/arm/mach-s3c24xx/mach-mini2440.c
> > +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
> > @@ -519,6 +519,7 @@ static struct platform_device *mini2440_devices[]
> > __initdata = { &s3c_device_iis,
> > &uda1340_codec,
> > &mini2440_audio,
> > + &s3c_device_timer[0],
> > };
>
> I think you need to add instead:
>
> &samsung_device_pwm,
>
> IIRC I had this working, can't verify at the moment as I don't
> have access to the board right now. Please see commit:
>
> 7fa33bdb4c44155e390c9ebbc5aa4c5cfc73f6fa
> ARM: SAMSUNG: Modify board files to use new PWM platform device
Seems valid for 3.12, but not for 3.11.
Regards,
Juergen
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: jbe@pengutronix.de (Jürgen Beisert)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM/Samsung/S3C24xx: Linux-3.11 crashes when using PWM
Date: Wed, 25 Sep 2013 11:40:36 +0200 [thread overview]
Message-ID: <201309251140.36582.jbe@pengutronix.de> (raw)
In-Reply-To: <5242AA7C.4010905@samsung.com>
Hi Sylwester,
On Wednesday 25 September 2013 11:18:52 Sylwester Nawrocki wrote:
> On 25/09/13 10:29, J?rgen Beisert wrote:
> > Change one single line:
> >
> > diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c
> > b/arch/arm/mach-s3c24xx/mach-mini2440.c index a83db46..d8273da 100644
> > --- a/arch/arm/mach-s3c24xx/mach-mini2440.c
> > +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
> > @@ -519,6 +519,7 @@ static struct platform_device *mini2440_devices[]
> > __initdata = { &s3c_device_iis,
> > &uda1340_codec,
> > &mini2440_audio,
> > + &s3c_device_timer[0],
> > };
>
> I think you need to add instead:
>
> &samsung_device_pwm,
>
> IIRC I had this working, can't verify at the moment as I don't
> have access to the board right now. Please see commit:
>
> 7fa33bdb4c44155e390c9ebbc5aa4c5cfc73f6fa
> ARM: SAMSUNG: Modify board files to use new PWM platform device
Seems valid for 3.12, but not for 3.11.
Regards,
Juergen
--
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Beisert ? ? ? ? ? ? |
Linux Solutions for Science and Industry ? ? ?| http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-09-25 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 8:29 ARM/Samsung/S3C24xx: Linux-3.11 crashes when using PWM Jürgen Beisert
2013-09-25 8:29 ` Jürgen Beisert
2013-09-25 9:18 ` Sylwester Nawrocki
2013-09-25 9:18 ` Sylwester Nawrocki
2013-09-25 9:40 ` Jürgen Beisert [this message]
2013-09-25 9:40 ` Jürgen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309251140.36582.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.