All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	xen-devel@lists.xensource.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	virtualization@lists.linux-foundation.org,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCHv2] tracing/events: Add bounce tracing to swiotbl
Date: Wed, 25 Sep 2013 13:56:49 -0400	[thread overview]
Message-ID: <20130925175649.GC7253@phenom.dumpdata.com> (raw)
In-Reply-To: <5239CF01.1010001@citrix.com>

On Wed, Sep 18, 2013 at 05:04:17PM +0100, Zoltan Kiss wrote:
> Hi,
> 
> I haven't got a reply in the past 2 weeks, so I would like to bump
> the patch, just to make sure it haven't fell off the radar.

Hey,

I have this in my queue to put on 3.13 as it is past the merge window.
.. with that in mind:


.. snip..
> >+	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx "
> >+		"size=%zu swiotlb_force=%x",
> >+		__get_str(dev_name),
> >+		__entry->dma_mask,
> >+		(unsigned long long)__entry->dev_addr,
> >+		__entry->size,
> >+		__entry->swiotlb_force)

Would it make sense to do something like this:

		__entry->swiotlb_force ? "swiotlb_force" : "")

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCHv2] tracing/events: Add bounce tracing to swiotbl
Date: Wed, 25 Sep 2013 13:56:49 -0400	[thread overview]
Message-ID: <20130925175649.GC7253@phenom.dumpdata.com> (raw)
In-Reply-To: <5239CF01.1010001@citrix.com>

On Wed, Sep 18, 2013 at 05:04:17PM +0100, Zoltan Kiss wrote:
> Hi,
> 
> I haven't got a reply in the past 2 weeks, so I would like to bump
> the patch, just to make sure it haven't fell off the radar.

Hey,

I have this in my queue to put on 3.13 as it is past the merge window.
.. with that in mind:


.. snip..
> >+	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx "
> >+		"size=%zu swiotlb_force=%x",
> >+		__get_str(dev_name),
> >+		__entry->dma_mask,
> >+		(unsigned long long)__entry->dev_addr,
> >+		__entry->size,
> >+		__entry->swiotlb_force)

Would it make sense to do something like this:

		__entry->swiotlb_force ? "swiotlb_force" : "")


  reply	other threads:[~2013-09-25 17:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 20:11 [PATCHv2] tracing/events: Add bounce tracing to swiotbl Zoltan Kiss
2013-09-04 20:11 ` Zoltan Kiss
2013-09-18 16:04 ` Zoltan Kiss
2013-09-18 16:04   ` Zoltan Kiss
2013-09-25 17:56   ` Konrad Rzeszutek Wilk [this message]
2013-09-25 17:56     ` Konrad Rzeszutek Wilk
2013-09-25 18:26     ` Steven Rostedt
2013-09-25 18:26     ` Steven Rostedt
2013-09-26 16:58     ` Zoltan Kiss
2013-09-26 16:58       ` Zoltan Kiss
2013-09-26 18:03       ` Konrad Rzeszutek Wilk
2013-09-26 18:03         ` Konrad Rzeszutek Wilk
  -- strict thread matches above, loose matches on Subject: below --
2013-09-04 20:11 Zoltan Kiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130925175649.GC7253@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=fweisbec@gmail.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    --cc=zoltan.kiss@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.