From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: OMAP2+: Use pdata quirks for wl12xx legacy init
Date: Wed, 25 Sep 2013 16:26:59 -0700 [thread overview]
Message-ID: <20130925232658.GD8949@atomide.com> (raw)
In-Reply-To: <20130920173821.2584.1124.stgit@localhost>
* Tony Lindgren <tony@atomide.com> [130920 10:46]:
> --- a/arch/arm/mach-omap2/pdata-quirks.c
> +++ b/arch/arm/mach-omap2/pdata-quirks.c
> +#if IS_ENABLED(CONFIG_WL12XX)
> +
> +static struct wl12xx_platform_data wl12xx __initdata;
> +
> +static void __init __used legacy_init_wl12xx(unsigned ref_clock,
> + unsigned tcxo_clock,
> + int gpio)
> +{
> + int res;
> +
> + wl12xx.board_ref_clock = ref_clock;
> + wl12xx.board_tcxo_clock = tcxo_clock;
> + wl12xx.irq = gpio_to_irq(gpio);
> +
> + res = wl12xx_set_platform_data(&wl12xx);
> + if (res) {
> + pr_err("error setting wl12xx data: %d\n", res);
> + return;
> + }
> +}
> +#else
> +static inline void omap_init_wl12xx_of(void)
> +{
> +}
> +#endif
> +
This should be legacy_init_wl12xx(unsigned ref_clock,
unsigned tcxo_clock, int gpio) instead of just
omap_init_wl12xx_of(void).
I've updated the patch and pushed this series to
omap-for-v3.13/quirk.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: OMAP2+: Use pdata quirks for wl12xx legacy init
Date: Wed, 25 Sep 2013 16:26:59 -0700 [thread overview]
Message-ID: <20130925232658.GD8949@atomide.com> (raw)
In-Reply-To: <20130920173821.2584.1124.stgit@localhost>
* Tony Lindgren <tony@atomide.com> [130920 10:46]:
> --- a/arch/arm/mach-omap2/pdata-quirks.c
> +++ b/arch/arm/mach-omap2/pdata-quirks.c
> +#if IS_ENABLED(CONFIG_WL12XX)
> +
> +static struct wl12xx_platform_data wl12xx __initdata;
> +
> +static void __init __used legacy_init_wl12xx(unsigned ref_clock,
> + unsigned tcxo_clock,
> + int gpio)
> +{
> + int res;
> +
> + wl12xx.board_ref_clock = ref_clock;
> + wl12xx.board_tcxo_clock = tcxo_clock;
> + wl12xx.irq = gpio_to_irq(gpio);
> +
> + res = wl12xx_set_platform_data(&wl12xx);
> + if (res) {
> + pr_err("error setting wl12xx data: %d\n", res);
> + return;
> + }
> +}
> +#else
> +static inline void omap_init_wl12xx_of(void)
> +{
> +}
> +#endif
> +
This should be legacy_init_wl12xx(unsigned ref_clock,
unsigned tcxo_clock, int gpio) instead of just
omap_init_wl12xx_of(void).
I've updated the patch and pushed this series to
omap-for-v3.13/quirk.
Regards,
Tony
next prev parent reply other threads:[~2013-09-25 23:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 17:38 [PATCH 0/4] Clean up legacy platform data handling for omaps for v3.13 Tony Lindgren
2013-09-20 17:38 ` Tony Lindgren
2013-09-20 17:38 ` [PATCH 1/4] ARM: OMAP2+: Always build in board-generic Tony Lindgren
2013-09-20 17:38 ` Tony Lindgren
2013-09-20 17:38 ` [PATCH 2/4] ARM: OMAP2+: Add quirk support for legacy platform data init Tony Lindgren
2013-09-20 17:38 ` Tony Lindgren
2013-09-20 17:38 ` [PATCH 3/4] ARM: OMAP2+: Use pdata quirk support for board-generic.c Tony Lindgren
2013-09-20 17:38 ` Tony Lindgren
2013-09-20 17:38 ` [PATCH 4/4] ARM: OMAP2+: Use pdata quirks for wl12xx legacy init Tony Lindgren
2013-09-20 17:38 ` Tony Lindgren
2013-09-25 23:26 ` Tony Lindgren [this message]
2013-09-25 23:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925232658.GD8949@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.