All of lore.kernel.org
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Sage Weil <sage@newdream.net>
Cc: linux-next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kent Overstreet <koverstreet@google.com>,
	Benjamin LaHaise <bcrl@kvack.org>
Subject: Re: linux-next: build failure after merge of the ceph tree
Date: Thu, 26 Sep 2013 09:20:39 +0800	[thread overview]
Message-ID: <201309260920374598440@gmail.com> (raw)
In-Reply-To: 20130926111500.cb583a5fe861bd4699a4e9d7@canb.auug.org.au

Sorry for that, i notice the commit 73a7075e3f6e.But i misread it.
I'll modify this as soon as possible.

Thanks!
Jianpeng Ma
>Hi Sage,
>
>After merging the ceph tree, today's linux-next build (x86_64
>allmodconfig) failed like this:
>
>In file included from include/linux/kernel.h:14:0,
>                 from include/linux/cache.h:4,
>                 from include/linux/time.h:4,
>                 from include/linux/stat.h:18,
>                 from include/linux/module.h:10,
>                 from fs/ceph/file.c:3:
>fs/ceph/file.c: In function 'ceph_sync_read':
>fs/ceph/file.c:421:21: error: 'struct kiocb' has no member named 'ki_left'
>       (unsigned)iocb->ki_left,
>                     ^
>include/linux/dynamic_debug.h:79:10: note: in definition of macro 'dynamic_pr_debug'
>        ##__VA_ARGS__);  \
>          ^
>include/linux/ceph/ceph_debug.h:17:2: note: in expansion of macro 'pr_debug'
>  pr_debug("%.*s %12.12s:%-4d : " fmt,    \
>  ^
>fs/ceph/file.c:420:2: note: in expansion of macro 'dout'
>  dout("sync_read on file %p %llu~%u %s\n", file, off,
>  ^
>fs/ceph/file.c:430:17: error: 'struct kiocb' has no member named 'ki_left'
>       off + iocb->ki_left);
>                 ^
>fs/ceph/file.c:436:25: error: 'struct iov_iter' has no member named 'iov'
>    void __user *data = i->iov[0].iov_base + i->iov_offset;
>                         ^
>fs/ceph/file.c:437:18: error: 'struct iov_iter' has no member named 'iov'
>    size_t len = i->iov[0].iov_len - i->iov_offset;
>                  ^
>fs/ceph/file.c:458:20: error: 'struct kiocb' has no member named 'ki_left'
>   size_t len = iocb->ki_left;
>                    ^
>fs/ceph/file.c:471:26: error: 'struct iov_iter' has no member named 'iov'
>     void __user *data = i->iov[0].iov_base
>                          ^
>In file included from include/linux/cache.h:4:0,
>                 from include/linux/time.h:4,
>                 from include/linux/stat.h:18,
>                 from include/linux/module.h:10,
>                 from fs/ceph/file.c:3:
>fs/ceph/file.c:473:14: error: 'struct iov_iter' has no member named 'iov'
>     l = min(i->iov[0].iov_len - i->iov_offset,
>              ^
>include/linux/kernel.h:670:9: note: in definition of macro 'min'
>  typeof(x) _min1 = (x);   \
>         ^
>fs/ceph/file.c:473:14: error: 'struct iov_iter' has no member named 'iov'
>     l = min(i->iov[0].iov_len - i->iov_offset,
>              ^
>include/linux/kernel.h:670:21: note: in definition of macro 'min'
>  typeof(x) _min1 = (x);   \
>                     ^
>include/linux/kernel.h:672:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>  (void) (&_min1 == &_min2);  \
>                 ^
>fs/ceph/file.c:473:9: note: in expansion of macro 'min'
>     l = min(i->iov[0].iov_len - i->iov_offset,
>         ^
>fs/ceph/file.c:496:7: error: 'struct kiocb' has no member named 'ki_left'
>   iocb->ki_left -= ret;
>       ^
>fs/ceph/file.c: In function 'ceph_sync_direct_write':
>fs/ceph/file.c:588:24: error: 'struct iov_iter' has no member named 'iov'
>   void __user *data = i.iov->iov_base + i.iov_offset;
>                        ^
>fs/ceph/file.c:589:14: error: 'struct iov_iter' has no member named 'iov'
>   u64 len = i.iov->iov_len - i.iov_offset;
>              ^
>fs/ceph/file.c: In function 'ceph_aio_read':
>fs/ceph/file.c:839:7: error: 'struct kiocb' has no member named 'ki_left'
>   iocb->ki_left = len;
>       ^
>fs/ceph/file.c:870:8: error: 'struct kiocb' has no member named 'ki_left'
>    iocb->ki_left) {
>        ^
>
>Caused by commit e6c9af8b8f11 ("ceph: implement readv/preadv for sync
>operation").  ki_left was removed by commit 73a7075e3f6e ("aio: Kill
>aio_rw_vect_retry()") during the merge window ... basing new work for
>v3.13 on v3.11 is a bit problematic.
>
>I have used the ceph tree from next-20130925 for today.
>
>-- 
>Cheers,
>Stephen Rothwell                    sfr@canb.auug.org.au
>

WARNING: multiple messages have this Message-ID (diff)
From: majianpeng <majianpeng@gmail.com>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Sage Weil" <sage@newdream.net>
Cc: linux-next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Kent Overstreet" <koverstreet@google.com>,
	"Benjamin LaHaise" <bcrl@kvack.org>
Subject: Re: linux-next: build failure after merge of the ceph tree
Date: Thu, 26 Sep 2013 09:20:39 +0800	[thread overview]
Message-ID: <201309260920374598440@gmail.com> (raw)
In-Reply-To: 20130926111500.cb583a5fe861bd4699a4e9d7@canb.auug.org.au

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 4096 bytes --]

Sorry for that, i notice the commit 73a7075e3f6e.But i misread it.
I'll modify this as soon as possible.

Thanks!
Jianpeng Ma
>Hi Sage,
>
>After merging the ceph tree, today's linux-next build (x86_64
>allmodconfig) failed like this:
>
>In file included from include/linux/kernel.h:14:0,
>                 from include/linux/cache.h:4,
>                 from include/linux/time.h:4,
>                 from include/linux/stat.h:18,
>                 from include/linux/module.h:10,
>                 from fs/ceph/file.c:3:
>fs/ceph/file.c: In function 'ceph_sync_read':
>fs/ceph/file.c:421:21: error: 'struct kiocb' has no member named 'ki_left'
>       (unsigned)iocb->ki_left,
>                     ^
>include/linux/dynamic_debug.h:79:10: note: in definition of macro 'dynamic_pr_debug'
>        ##__VA_ARGS__);  \
>          ^
>include/linux/ceph/ceph_debug.h:17:2: note: in expansion of macro 'pr_debug'
>  pr_debug("%.*s %12.12s:%-4d : " fmt,    \
>  ^
>fs/ceph/file.c:420:2: note: in expansion of macro 'dout'
>  dout("sync_read on file %p %llu~%u %s\n", file, off,
>  ^
>fs/ceph/file.c:430:17: error: 'struct kiocb' has no member named 'ki_left'
>       off + iocb->ki_left);
>                 ^
>fs/ceph/file.c:436:25: error: 'struct iov_iter' has no member named 'iov'
>    void __user *data = i->iov[0].iov_base + i->iov_offset;
>                         ^
>fs/ceph/file.c:437:18: error: 'struct iov_iter' has no member named 'iov'
>    size_t len = i->iov[0].iov_len - i->iov_offset;
>                  ^
>fs/ceph/file.c:458:20: error: 'struct kiocb' has no member named 'ki_left'
>   size_t len = iocb->ki_left;
>                    ^
>fs/ceph/file.c:471:26: error: 'struct iov_iter' has no member named 'iov'
>     void __user *data = i->iov[0].iov_base
>                          ^
>In file included from include/linux/cache.h:4:0,
>                 from include/linux/time.h:4,
>                 from include/linux/stat.h:18,
>                 from include/linux/module.h:10,
>                 from fs/ceph/file.c:3:
>fs/ceph/file.c:473:14: error: 'struct iov_iter' has no member named 'iov'
>     l = min(i->iov[0].iov_len - i->iov_offset,
>              ^
>include/linux/kernel.h:670:9: note: in definition of macro 'min'
>  typeof(x) _min1 = (x);   \
>         ^
>fs/ceph/file.c:473:14: error: 'struct iov_iter' has no member named 'iov'
>     l = min(i->iov[0].iov_len - i->iov_offset,
>              ^
>include/linux/kernel.h:670:21: note: in definition of macro 'min'
>  typeof(x) _min1 = (x);   \
>                     ^
>include/linux/kernel.h:672:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>  (void) (&_min1 == &_min2);  \
>                 ^
>fs/ceph/file.c:473:9: note: in expansion of macro 'min'
>     l = min(i->iov[0].iov_len - i->iov_offset,
>         ^
>fs/ceph/file.c:496:7: error: 'struct kiocb' has no member named 'ki_left'
>   iocb->ki_left -= ret;
>       ^
>fs/ceph/file.c: In function 'ceph_sync_direct_write':
>fs/ceph/file.c:588:24: error: 'struct iov_iter' has no member named 'iov'
>   void __user *data = i.iov->iov_base + i.iov_offset;
>                        ^
>fs/ceph/file.c:589:14: error: 'struct iov_iter' has no member named 'iov'
>   u64 len = i.iov->iov_len - i.iov_offset;
>              ^
>fs/ceph/file.c: In function 'ceph_aio_read':
>fs/ceph/file.c:839:7: error: 'struct kiocb' has no member named 'ki_left'
>   iocb->ki_left = len;
>       ^
>fs/ceph/file.c:870:8: error: 'struct kiocb' has no member named 'ki_left'
>    iocb->ki_left) {
>        ^
>
>Caused by commit e6c9af8b8f11 ("ceph: implement readv/preadv for sync
>operation").  ki_left was removed by commit 73a7075e3f6e ("aio: Kill
>aio_rw_vect_retry()") during the merge window ... basing new work for
>v3.13 on v3.11 is a bit problematic.
>
>I have used the ceph tree from next-20130925 for today.
>
>-- 
>Cheers,
>Stephen Rothwell                    sfr@canb.auug.org.au
>ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2013-09-26  1:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  1:15 linux-next: build failure after merge of the ceph tree Stephen Rothwell
2013-09-26  1:20 ` majianpeng [this message]
2013-09-26  1:20   ` majianpeng
2013-09-26  1:26   ` Sage Weil
  -- strict thread matches above, loose matches on Subject: below --
2020-12-14 23:46 Stephen Rothwell
2013-09-27  1:31 Stephen Rothwell
2013-09-27  2:36 ` Dave Kleikamp
2012-03-21  1:40 Stephen Rothwell
2012-03-21  4:24 ` Alex Elder
2010-11-16 23:43 Stephen Rothwell
2010-11-17  0:02 ` Sage Weil
2010-09-20  1:41 Stephen Rothwell
2010-09-20  2:53 ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309260920374598440@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=bcrl@kvack.org \
    --cc=koverstreet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sage@newdream.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.