All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: mxsfb: Add missing break
Date: Thu, 26 Sep 2013 13:04:44 +0000	[thread overview]
Message-ID: <201309261504.45088.marex@denx.de> (raw)
In-Reply-To: <524429C0.2020907@ti.com>

Hi Tomi,

> On 26/09/13 14:13, Marek Vasut wrote:
> > Add missing break into the restore function.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > 
> >  drivers/video/mxsfb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> > index d250ed0..27197a8 100644
> > --- a/drivers/video/mxsfb.c
> > +++ b/drivers/video/mxsfb.c
> > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
> > *host)
> > 
> >  		break;
> >  	
> >  	case 3:
> >  		bits_per_pixel = 32;
> > 
> > +		break;
> > 
> >  	case 1:
> >  	
> >  	default:
> >  		return -EINVAL;
> 
> Thanks, queued for 3.12 fixes.

Can you please also queue this for stable 3.10? It's broken there too.

Thanks!

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video: mxsfb: Add missing break
Date: Thu, 26 Sep 2013 15:04:44 +0200	[thread overview]
Message-ID: <201309261504.45088.marex@denx.de> (raw)
In-Reply-To: <524429C0.2020907@ti.com>

Hi Tomi,

> On 26/09/13 14:13, Marek Vasut wrote:
> > Add missing break into the restore function.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > 
> >  drivers/video/mxsfb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> > index d250ed0..27197a8 100644
> > --- a/drivers/video/mxsfb.c
> > +++ b/drivers/video/mxsfb.c
> > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
> > *host)
> > 
> >  		break;
> >  	
> >  	case 3:
> >  		bits_per_pixel = 32;
> > 
> > +		break;
> > 
> >  	case 1:
> >  	
> >  	default:
> >  		return -EINVAL;
> 
> Thanks, queued for 3.12 fixes.

Can you please also queue this for stable 3.10? It's broken there too.

Thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-26 13:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 11:13 [PATCH] video: mxsfb: Add missing break Marek Vasut
2013-09-26 11:13 ` Marek Vasut
2013-09-26 12:34 ` Tomi Valkeinen
2013-09-26 12:34   ` Tomi Valkeinen
2013-09-26 13:04   ` Marek Vasut [this message]
2013-09-26 13:04     ` Marek Vasut
2013-09-27  3:59     ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  3:59       ` Jean-Christophe PLAGNIOL-VILLARD
  -- strict thread matches above, loose matches on Subject: below --
2013-10-01  4:22 Marek Vasut
2013-10-03 16:15 ` Luis Henriques
2013-10-03 16:26   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309261504.45088.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.