All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: omap: Fix default value of mci.f_max
Date: Fri, 27 Sep 2013 14:19:21 +0200	[thread overview]
Message-ID: <20130927121920.GA526@omega> (raw)
In-Reply-To: <1380283980-5759-1-git-send-email-t.gamez@phytec.de>

Hi,

On Fri, Sep 27, 2013 at 02:13:00PM +0200, Teresa Gámez wrote:
> Set default value of mci.f_max even when no pdata
> is available.
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
>  drivers/mci/omap_hsmmc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> index a2cd3fe..f63697f 100644
> --- a/drivers/mci/omap_hsmmc.c
> +++ b/drivers/mci/omap_hsmmc.c
> @@ -614,11 +614,11 @@ static int omap_mmc_probe(struct device_d *dev)
>  	if (pdata) {
>  		if (pdata->f_max)
>  			hsmmc->mci.f_max = pdata->f_max;
> -		else
> -			hsmmc->mci.f_max = 52000000;

I think this should stay there for the case if f_max is zero.
So somebody sets a pdata with devname and no f_max value.


Maybe you should add a default devname if no pdata is given.

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-09-27 12:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 12:13 [PATCH] mci: omap: Fix default value of mci.f_max Teresa Gámez
2013-09-27 12:19 ` Alexander Aring [this message]
2013-09-27 13:29   ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27 13:36     ` Alexander Aring
2013-09-27 13:38 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27 13:40   ` Alexander Aring
2013-09-27 13:45     ` Alexander Aring
2013-09-27 13:52       ` Teresa Gamez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927121920.GA526@omega \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=t.gamez@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.