Re: [PATCH] mci: omap: Fix default value of mci.f_max

[Alexander Aring <alex.aring@gmail.com>]

Hi,

On Fri, Sep 27, 2013 at 03:29:40PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:19 Fri 27 Sep     , Alexander Aring wrote:
> > Hi,
> > 
> > On Fri, Sep 27, 2013 at 02:13:00PM +0200, Teresa Gámez wrote:
> > > Set default value of mci.f_max even when no pdata
> > > is available.
> > > 
> > > Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> > > ---
> > >  drivers/mci/omap_hsmmc.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> > > index a2cd3fe..f63697f 100644
> > > --- a/drivers/mci/omap_hsmmc.c
> > > +++ b/drivers/mci/omap_hsmmc.c
> > > @@ -614,11 +614,11 @@ static int omap_mmc_probe(struct device_d *dev)
> > >  	if (pdata) {
> > >  		if (pdata->f_max)
> > >  			hsmmc->mci.f_max = pdata->f_max;
> > > -		else
> > > -			hsmmc->mci.f_max = 52000000;
> > 
> > I think this should stay there for the case if f_max is zero.
> > So somebody sets a pdata with devname and no f_max value.
> > 
> > 
> > Maybe you should add a default devname if no pdata is given.
> no there is a default devname disk.%d
oh yea, I saw that right now. But the upper branch should stay there for
a unusal case if somebody set's a devname but no f_max attribute.

Don't know if any board do this right now.

At the comments from "struct omap_hsmmc_platform_data" f_max is not
optional so maybe it should run in a panic or we hold a backwards
compatibility.

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox