* Re: [PATCH 3/3] meta-toolchain-arago: Remove TARGET_SYS env variable
2013-09-30 23:19 ` [PATCH 3/3] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
@ 2013-09-30 22:48 ` Denys Dmytriyenko
0 siblings, 0 replies; 4+ messages in thread
From: Denys Dmytriyenko @ 2013-09-30 22:48 UTC (permalink / raw)
To: Franklin S. Cooper Jr; +Cc: meta-arago
On Mon, Sep 30, 2013 at 06:19:28PM -0500, Franklin S. Cooper Jr wrote:
> * Within environment-setup the TARGET_SYS variable is exported but used
> improperly.
> * The value for --target and --host isn't the TARGET_SYS value within the
> environment-setup file but rather the OE variable TARGET_SYS.
> * Cross compiling autotools based applications using environment-setup
> results in host and machine not recognized "configure" errors.
Good catch. But I would like to keep TARGET_SYS env, maybe name it
differently, instead of hardcoding REAL_MULTIMACH_TARGET_SYS in multiple
places. Actually, why not re-use that long name for the variable?
And for autotools configure flags, we should pass ${TARGET_SYS} instead of
$TARGET_SYS - like in your patch.
See my comments below for what I'm thinking.
> * Looking at toolchain-scripts.bbclass it looks like that variable has been
> removed from environment-setup so mimic that change.
>
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
> .../recipes-core/meta/meta-toolchain-arago.bb | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> index a8da4dc..2ab3b8d 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> @@ -30,17 +30,16 @@ toolchain_create_sdk_env_script () {
> echo ' export SDK_PATH' >> $script
> echo 'fi' >> $script
> echo 'export SDK_SYS=${SDK_SYS}' >> $script
> - echo 'export TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script
Don't remove, but change the var name:
echo 'export REAL_MULTIMACH_TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script
> echo 'export TOOLCHAIN_SYS=${TOOLCHAIN_SYS}' >> $script
> echo 'export TOOLCHAIN_PREFIX=$TOOLCHAIN_SYS-' >> $script
> echo 'export SDK_PATH_NATIVE=$SDK_PATH/sysroots/$SDK_SYS' >> $script
> - echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$TARGET_SYS' >> $script
> + echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/${REAL_MULTIMACH_TARGET_SYS}' >> $script
Replace with this:
echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$REAL_MULTIMACH_TARGET_SYS' >> $script
> echo 'export PATH=$SDK_PATH_NATIVE${bindir_nativesdk}:$PATH' >> $script
> echo 'export CPATH=$SDK_PATH_TARGET/usr/include:$CPATH' >> $script
> echo 'export PKG_CONFIG_SYSROOT_DIR=$SDK_PATH_TARGET' >> $script
> echo 'export PKG_CONFIG_PATH=$SDK_PATH_TARGET${libdir}/pkgconfig' >> $script
> echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> - echo 'export CONFIG_SITE=$SDK_PATH/site-config-$TARGET_SYS' >> $script
> + echo 'export CONFIG_SITE=$SDK_PATH/site-config-${REAL_MULTIMACH_TARGET_SYS}' >> $script
Replace with this:
echo 'export CONFIG_SITE=$SDK_PATH/site-config-$REAL_MULTIMACH_TARGET_SYS' >> $script
> printf 'export CC=\x24{TOOLCHAIN_PREFIX}gcc\n' >> $script
> printf 'export CXX=\x24{TOOLCHAIN_PREFIX}g++\n' >> $script
> printf 'export GDB=\x24{TOOLCHAIN_PREFIX}gdb\n' >> $script
> @@ -52,7 +51,7 @@ toolchain_create_sdk_env_script () {
> printf 'export OBJCOPY=\x24{TOOLCHAIN_PREFIX}objcopy\n' >> $script
> printf 'export OBJDUMP=\x24{TOOLCHAIN_PREFIX}objdump\n' >> $script
> printf 'export STRIP=\x24{TOOLCHAIN_PREFIX}strip\n' >> $script
> - echo 'export CONFIGURE_FLAGS="--target=$TARGET_SYS --host=$TARGET_SYS --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
> + echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
Keep this change the same.
> echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=$SDK_PATH_TARGET"' >> $script
> echo 'export CFLAGS="$CPPFLAGS"' >> $script
> echo 'export CXXFLAGS="$CPPFLAGS"' >> $script
> --
> 1.7.0.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] packagegroup-arago-console: Add additional packages needed to partition eMMC
@ 2013-09-30 23:19 Franklin S. Cooper Jr
2013-09-30 23:19 ` [PATCH 2/3] arago-source-ipk.conf: Remove PR from u-boot-ti-staging Franklin S. Cooper Jr
2013-09-30 23:19 ` [PATCH 3/3] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
0 siblings, 2 replies; 4+ messages in thread
From: Franklin S. Cooper Jr @ 2013-09-30 23:19 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S. Cooper Jr
Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
.../packagegroups/packagegroup-arago-console.bb | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
index f625a28..8d65cac 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
@@ -1,6 +1,6 @@
DESCRIPTION = "Extended task to get more basic and console apps"
LICENSE = "MIT"
-PR = "r5"
+PR = "r6"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -42,6 +42,8 @@ ARAGO_FSTOOLS = "\
e2fsprogs-tune2fs \
dosfstools \
util-linux-fdisk \
+ util-linux-mkfs \
+ util-linux-sfdisk \
"
ARAGO_UTILS = "\
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] arago-source-ipk.conf: Remove PR from u-boot-ti-staging
2013-09-30 23:19 [PATCH 1/3] packagegroup-arago-console: Add additional packages needed to partition eMMC Franklin S. Cooper Jr
@ 2013-09-30 23:19 ` Franklin S. Cooper Jr
2013-09-30 23:19 ` [PATCH 3/3] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
1 sibling, 0 replies; 4+ messages in thread
From: Franklin S. Cooper Jr @ 2013-09-30 23:19 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S. Cooper Jr
* In the sources directory name the PR is unnecessary and also confusing for
users.
* This also matches the look of linux-ti-staging sources directory.
Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
.../conf/distro/arago-source-ipk.conf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf b/meta-arago-distro/conf/distro/arago-source-ipk.conf
index a321271..ef41d94 100644
--- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
+++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
@@ -119,7 +119,7 @@ SRCIPK_INSTALL_DIR_pn-x-load_beagleboard = "board-support/${P}"
SRCIPK_PACKAGE_ARCH_pn-x-load = "${MACHINE_ARCH}"
CREATE_SRCIPK_pn-u-boot-ti-staging = "1"
-SRCIPK_INSTALL_DIR_pn-u-boot-ti-staging = "board-support/u-boot-${PV}-${PR}"
+SRCIPK_INSTALL_DIR_pn-u-boot-ti-staging = "board-support/u-boot-${PV}"
SRCIPK_PACKAGE_ARCH_pn-u-boot-ti-staging = "${MACHINE_ARCH}"
SRCIPK_PRESERVE_GIT_pn-u-boot-ti-staging = "true"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] meta-toolchain-arago: Remove TARGET_SYS env variable
2013-09-30 23:19 [PATCH 1/3] packagegroup-arago-console: Add additional packages needed to partition eMMC Franklin S. Cooper Jr
2013-09-30 23:19 ` [PATCH 2/3] arago-source-ipk.conf: Remove PR from u-boot-ti-staging Franklin S. Cooper Jr
@ 2013-09-30 23:19 ` Franklin S. Cooper Jr
2013-09-30 22:48 ` Denys Dmytriyenko
1 sibling, 1 reply; 4+ messages in thread
From: Franklin S. Cooper Jr @ 2013-09-30 23:19 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S. Cooper Jr
* Within environment-setup the TARGET_SYS variable is exported but used
improperly.
* The value for --target and --host isn't the TARGET_SYS value within the
environment-setup file but rather the OE variable TARGET_SYS.
* Cross compiling autotools based applications using environment-setup
results in host and machine not recognized "configure" errors.
* Looking at toolchain-scripts.bbclass it looks like that variable has been
removed from environment-setup so mimic that change.
Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
.../recipes-core/meta/meta-toolchain-arago.bb | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
index a8da4dc..2ab3b8d 100644
--- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
+++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
@@ -30,17 +30,16 @@ toolchain_create_sdk_env_script () {
echo ' export SDK_PATH' >> $script
echo 'fi' >> $script
echo 'export SDK_SYS=${SDK_SYS}' >> $script
- echo 'export TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script
echo 'export TOOLCHAIN_SYS=${TOOLCHAIN_SYS}' >> $script
echo 'export TOOLCHAIN_PREFIX=$TOOLCHAIN_SYS-' >> $script
echo 'export SDK_PATH_NATIVE=$SDK_PATH/sysroots/$SDK_SYS' >> $script
- echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$TARGET_SYS' >> $script
+ echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/${REAL_MULTIMACH_TARGET_SYS}' >> $script
echo 'export PATH=$SDK_PATH_NATIVE${bindir_nativesdk}:$PATH' >> $script
echo 'export CPATH=$SDK_PATH_TARGET/usr/include:$CPATH' >> $script
echo 'export PKG_CONFIG_SYSROOT_DIR=$SDK_PATH_TARGET' >> $script
echo 'export PKG_CONFIG_PATH=$SDK_PATH_TARGET${libdir}/pkgconfig' >> $script
echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
- echo 'export CONFIG_SITE=$SDK_PATH/site-config-$TARGET_SYS' >> $script
+ echo 'export CONFIG_SITE=$SDK_PATH/site-config-${REAL_MULTIMACH_TARGET_SYS}' >> $script
printf 'export CC=\x24{TOOLCHAIN_PREFIX}gcc\n' >> $script
printf 'export CXX=\x24{TOOLCHAIN_PREFIX}g++\n' >> $script
printf 'export GDB=\x24{TOOLCHAIN_PREFIX}gdb\n' >> $script
@@ -52,7 +51,7 @@ toolchain_create_sdk_env_script () {
printf 'export OBJCOPY=\x24{TOOLCHAIN_PREFIX}objcopy\n' >> $script
printf 'export OBJDUMP=\x24{TOOLCHAIN_PREFIX}objdump\n' >> $script
printf 'export STRIP=\x24{TOOLCHAIN_PREFIX}strip\n' >> $script
- echo 'export CONFIGURE_FLAGS="--target=$TARGET_SYS --host=$TARGET_SYS --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
+ echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=$SDK_PATH_TARGET"' >> $script
echo 'export CFLAGS="$CPPFLAGS"' >> $script
echo 'export CXXFLAGS="$CPPFLAGS"' >> $script
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-30 22:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 23:19 [PATCH 1/3] packagegroup-arago-console: Add additional packages needed to partition eMMC Franklin S. Cooper Jr
2013-09-30 23:19 ` [PATCH 2/3] arago-source-ipk.conf: Remove PR from u-boot-ti-staging Franklin S. Cooper Jr
2013-09-30 23:19 ` [PATCH 3/3] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
2013-09-30 22:48 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.