From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag
Date: Tue, 01 Oct 2013 03:48:35 +0000 [thread overview]
Message-ID: <20131001034831.GA3083@verge.net.au> (raw)
In-Reply-To: <27072275.6rIbiFzHY2@avalon>
On Mon, Sep 30, 2013 at 08:31:05PM +0200, Laurent Pinchart wrote:
> On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote:
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, I will queue this up.
>
> > ---
> > v2:
> > - use __initdata as it is OK to do it
> >
> > arch/arm/mach-shmobile/board-ape6evm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c
> > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644
> > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = {
> > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"),
> > };
> >
> > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = {
> > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = {
> > .buttons = gpio_buttons,
> > .nbuttons = ARRAY_SIZE(gpio_buttons),
> > };
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag
Date: Tue, 1 Oct 2013 12:48:35 +0900 [thread overview]
Message-ID: <20131001034831.GA3083@verge.net.au> (raw)
In-Reply-To: <27072275.6rIbiFzHY2@avalon>
On Mon, Sep 30, 2013 at 08:31:05PM +0200, Laurent Pinchart wrote:
> On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote:
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, I will queue this up.
>
> > ---
> > v2:
> > - use __initdata as it is OK to do it
> >
> > arch/arm/mach-shmobile/board-ape6evm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c
> > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644
> > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = {
> > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"),
> > };
> >
> > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = {
> > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = {
> > .buttons = gpio_buttons,
> > .nbuttons = ARRAY_SIZE(gpio_buttons),
> > };
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag
Date: Tue, 1 Oct 2013 12:48:35 +0900 [thread overview]
Message-ID: <20131001034831.GA3083@verge.net.au> (raw)
In-Reply-To: <27072275.6rIbiFzHY2@avalon>
On Mon, Sep 30, 2013 at 08:31:05PM +0200, Laurent Pinchart wrote:
> On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote:
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, I will queue this up.
>
> > ---
> > v2:
> > - use __initdata as it is OK to do it
> >
> > arch/arm/mach-shmobile/board-ape6evm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c
> > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644
> > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = {
> > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"),
> > };
> >
> > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = {
> > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = {
> > .buttons = gpio_buttons,
> > .nbuttons = ARRAY_SIZE(gpio_buttons),
> > };
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-10-01 3:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 15:34 [PATCH v2] ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-09-30 15:34 ` Bartlomiej Zolnierkiewicz
2013-09-30 15:34 ` Bartlomiej Zolnierkiewicz
2013-09-30 18:31 ` Laurent Pinchart
2013-09-30 18:31 ` Laurent Pinchart
2013-09-30 18:31 ` Laurent Pinchart
2013-10-01 3:48 ` Simon Horman [this message]
2013-10-01 3:48 ` Simon Horman
2013-10-01 3:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001034831.GA3083@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.