From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: takasi-y@ops.dti.ne.jp, SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
ben.dooks@codethink.co.uk,
Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings
Date: Wed, 02 Oct 2013 01:28:37 +0000 [thread overview]
Message-ID: <20131002012837.GA29457@verge.net.au> (raw)
In-Reply-To: <21574726.tiJa6Opb1k@avalon>
On Tue, Oct 01, 2013 at 01:36:33PM +0200, Laurent Pinchart wrote:
> Hi Yoshii-san and Simon,
>
> On Tuesday 24 September 2013 13:52:15 Simon Horman wrote:
> > [ Cc Laurent ]
> >
> > On Tue, Sep 24, 2013 at 01:13:31PM +0900, takasi-y@ops.dti.ne.jp wrote:
> > > Device tree clock binding document for EMMA Mobile EV2 SMU.
> > > Following nodes are defined to describe clock tree.
> > > - renesas,emev2-smu
> > > - renesas,emev2-smu-clkdiv
> > > - renesas,emev2-smu-gclk
> >
> > I realise this has been entirely consistent in the past and
> > even as recently as Linus' pre v3.12-rc2 master branch.
> > However, after some recent discussion we are now trying to make our
> > compatibility strings consistently of the form renesas,<unit>-<soc>.
> >
> > With this in mind I believe the strings should be:
> >
> > - renesas,smu-emev2
> > - renesas,smu-clkdiv-emev2
> > - renesas,smu-gclk-emev2
> >
> > To be honest I am not quite sure about the "-clkdiv" and "-gclk"
> > bits and I would appreciate some review from others.
>
> I don't have access to the EMEV2 datasheet so my ability to comment on this is
> somehow limited. However, given that the clock hardware is very SoC-specific,
> it might make sense to keep the names proposed by Yoshii-san. This would be
> consistent with the other clock bindings.
Thanks Laurent. If that seems fine by you then it is fine by me.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: takasi-y@ops.dti.ne.jp, SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
ben.dooks@codethink.co.uk,
Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings
Date: Wed, 2 Oct 2013 10:28:37 +0900 [thread overview]
Message-ID: <20131002012837.GA29457@verge.net.au> (raw)
In-Reply-To: <21574726.tiJa6Opb1k@avalon>
On Tue, Oct 01, 2013 at 01:36:33PM +0200, Laurent Pinchart wrote:
> Hi Yoshii-san and Simon,
>
> On Tuesday 24 September 2013 13:52:15 Simon Horman wrote:
> > [ Cc Laurent ]
> >
> > On Tue, Sep 24, 2013 at 01:13:31PM +0900, takasi-y@ops.dti.ne.jp wrote:
> > > Device tree clock binding document for EMMA Mobile EV2 SMU.
> > > Following nodes are defined to describe clock tree.
> > > - renesas,emev2-smu
> > > - renesas,emev2-smu-clkdiv
> > > - renesas,emev2-smu-gclk
> >
> > I realise this has been entirely consistent in the past and
> > even as recently as Linus' pre v3.12-rc2 master branch.
> > However, after some recent discussion we are now trying to make our
> > compatibility strings consistently of the form renesas,<unit>-<soc>.
> >
> > With this in mind I believe the strings should be:
> >
> > - renesas,smu-emev2
> > - renesas,smu-clkdiv-emev2
> > - renesas,smu-gclk-emev2
> >
> > To be honest I am not quite sure about the "-clkdiv" and "-gclk"
> > bits and I would appreciate some review from others.
>
> I don't have access to the EMEV2 datasheet so my ability to comment on this is
> somehow limited. However, given that the clock hardware is very SoC-specific,
> it might make sense to keep the names proposed by Yoshii-san. This would be
> consistent with the other clock bindings.
Thanks Laurent. If that seems fine by you then it is fine by me.
next prev parent reply other threads:[~2013-10-02 1:28 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 4:05 [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT Takashi Yoshii
2013-09-24 4:05 ` Takashi Yoshii
2013-09-24 4:09 ` [PATCH 1/6] clocksource: em_sti: convert to clk_prepare/unprepare takasi-y
2013-09-24 4:09 ` takasi-y
2013-09-24 4:42 ` Simon Horman
2013-09-24 4:42 ` Simon Horman
2013-09-26 10:18 ` Daniel Lezcano
2013-09-26 10:18 ` Daniel Lezcano
[not found] ` <20130924130924.61d4ecedf3d4fca5952d55fc-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-09-30 15:25 ` Laurent Pinchart
2013-09-30 15:25 ` Laurent Pinchart
2013-09-30 15:25 ` Laurent Pinchart
[not found] ` <52440A07.4050101-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-10-03 2:30 ` Simon Horman
2013-10-03 2:30 ` Simon Horman
2013-10-03 2:30 ` Simon Horman
2013-10-01 9:05 ` Magnus Damm
2013-10-01 9:05 ` Magnus Damm
2013-10-01 9:05 ` Magnus Damm
2013-09-24 4:10 ` [PATCH 2/6] serial8250-em: " takasi-y
2013-09-24 4:10 ` takasi-y
2013-09-24 4:44 ` Simon Horman
2013-09-24 4:44 ` Simon Horman
2013-09-24 13:41 ` Greg Kroah-Hartman
2013-09-24 13:41 ` Greg Kroah-Hartman
2013-09-30 15:25 ` Laurent Pinchart
2013-09-30 15:25 ` Laurent Pinchart
[not found] ` <20130924134113.GA7246-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-10-03 2:30 ` Simon Horman
2013-10-03 2:30 ` Simon Horman
2013-10-03 2:30 ` Simon Horman
[not found] ` <20130924131039.3c871cad7acb2a068a988d0f-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-10-01 9:07 ` Magnus Damm
2013-10-01 9:07 ` Magnus Damm
2013-10-01 9:07 ` Magnus Damm
2013-09-24 4:12 ` [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively takasi-y
2013-09-24 4:12 ` takasi-y
2013-09-30 18:40 ` Laurent Pinchart
2013-09-30 18:40 ` Laurent Pinchart
2013-10-04 5:25 ` takasi-y
2013-10-04 5:25 ` takasi-y
2013-10-04 5:25 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-10-01 9:30 ` Magnus Damm
2013-10-01 9:30 ` Magnus Damm
2013-09-24 4:13 ` [PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings takasi-y
2013-09-24 4:13 ` takasi-y
[not found] ` <20130924131331.0e9a5f830f531655b2ea0ebe-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-09-24 4:52 ` Simon Horman
2013-09-24 4:52 ` Simon Horman
2013-09-24 4:52 ` Simon Horman
2013-09-24 9:00 ` takashi.yoshii.zj
2013-09-24 9:00 ` takashi.yoshii.zj
[not found] ` <20130924045215.GE3619-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-10-01 11:36 ` Laurent Pinchart
2013-10-01 11:36 ` Laurent Pinchart
2013-10-01 11:36 ` Laurent Pinchart
2013-10-02 1:28 ` Simon Horman [this message]
2013-10-02 1:28 ` Simon Horman
2013-10-06 17:16 ` Takashi YOSHII
2013-10-06 17:16 ` Takashi YOSHII
2013-10-06 17:16 ` Takashi YOSHII
2013-09-24 4:56 ` [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT Simon Horman
2013-09-24 4:56 ` Simon Horman
[not found] ` <52410F86.4040301-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2013-09-24 4:15 ` [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks " takasi-y
2013-09-24 4:15 ` takasi-y
2013-09-24 4:15 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
[not found] ` <20130924131542.f865fad4dec98e024c0d4676-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-10-01 9:15 ` Magnus Damm
2013-10-01 9:15 ` Magnus Damm
2013-10-01 9:15 ` Magnus Damm
2013-10-01 12:27 ` Laurent Pinchart
2013-10-01 12:27 ` Laurent Pinchart
2013-10-01 12:27 ` Laurent Pinchart
[not found] ` <CANqRtoRD35Ei31PK8a_TOp=2uiYPCoaJuDb6tyZtQL8s0PavNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-04 5:44 ` takasi-y
2013-10-04 5:44 ` takasi-y
2013-10-04 5:44 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-09-24 4:17 ` [PATCH 6/6] ARM: shmobile: kzm9d-reference: Use common clock framework takasi-y
2013-09-24 4:17 ` takasi-y
2013-09-24 4:17 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-09-24 4:55 ` Simon Horman
2013-09-24 4:55 ` Simon Horman
2013-10-01 9:23 ` Magnus Damm
2013-10-01 9:23 ` Magnus Damm
2013-09-25 7:17 ` [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT Kuninori Morimoto
2013-09-25 7:17 ` Kuninori Morimoto
2013-09-25 7:17 ` Kuninori Morimoto
[not found] ` <87siwtl69z.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2013-10-04 1:12 ` takasi-y
2013-10-04 1:12 ` takasi-y
2013-10-04 1:12 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002012837.GA29457@verge.net.au \
--to=horms@verge.net.au \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@linaro.org \
--cc=shinya.kuribayashi.px@renesas.com \
--cc=takasi-y@ops.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.