All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: anthony@codemonkey.ws
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [PULL 6/6] vfio: Fix debug output for int128 values
Date: Thu, 03 Oct 2013 09:39:58 -0600	[thread overview]
Message-ID: <20131003153943.26487.458.stgit@bling.home> (raw)
In-Reply-To: <20131003153601.26487.70022.stgit@bling.home>

From: Alexey Kardashevskiy <aik@ozlabs.ru>

Memory regions can easily be 2^64 byte long and therefore overflow
for just a bit but that is enough for int128_get64() to assert.

This takes care of debug printing of huge section sizes.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/misc/vfio.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 0c9bb95..68e25bd 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -2084,7 +2084,8 @@ static void vfio_listener_region_add(MemoryListener *listener,
     if (vfio_listener_skipped_section(section)) {
         DPRINTF("SKIPPING region_add %"HWADDR_PRIx" - %"PRIx64"\n",
                 section->offset_within_address_space,
-                section->offset_within_address_space + section->size - 1);
+                section->offset_within_address_space +
+                int128_get64(int128_sub(section->size, int128_one())));
         return;
     }
 
@@ -2129,7 +2130,8 @@ static void vfio_listener_region_del(MemoryListener *listener,
     if (vfio_listener_skipped_section(section)) {
         DPRINTF("SKIPPING region_del %"HWADDR_PRIx" - %"PRIx64"\n",
                 section->offset_within_address_space,
-                section->offset_within_address_space + section->size - 1);
+                section->offset_within_address_space +
+                int128_get64(int128_sub(section->size, int128_one())));
         return;
     }
 


WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: anthony@codemonkey.ws
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PULL 6/6] vfio: Fix debug output for int128 values
Date: Thu, 03 Oct 2013 09:39:58 -0600	[thread overview]
Message-ID: <20131003153943.26487.458.stgit@bling.home> (raw)
In-Reply-To: <20131003153601.26487.70022.stgit@bling.home>

From: Alexey Kardashevskiy <aik@ozlabs.ru>

Memory regions can easily be 2^64 byte long and therefore overflow
for just a bit but that is enough for int128_get64() to assert.

This takes care of debug printing of huge section sizes.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/misc/vfio.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 0c9bb95..68e25bd 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -2084,7 +2084,8 @@ static void vfio_listener_region_add(MemoryListener *listener,
     if (vfio_listener_skipped_section(section)) {
         DPRINTF("SKIPPING region_add %"HWADDR_PRIx" - %"PRIx64"\n",
                 section->offset_within_address_space,
-                section->offset_within_address_space + section->size - 1);
+                section->offset_within_address_space +
+                int128_get64(int128_sub(section->size, int128_one())));
         return;
     }
 
@@ -2129,7 +2130,8 @@ static void vfio_listener_region_del(MemoryListener *listener,
     if (vfio_listener_skipped_section(section)) {
         DPRINTF("SKIPPING region_del %"HWADDR_PRIx" - %"PRIx64"\n",
                 section->offset_within_address_space,
-                section->offset_within_address_space + section->size - 1);
+                section->offset_within_address_space +
+                int128_get64(int128_sub(section->size, int128_one())));
         return;
     }
 

  parent reply	other threads:[~2013-10-03 15:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 15:38 [PULL 0/6] VFIO updates for QEMU Alex Williamson
2013-10-03 15:38 ` [Qemu-devel] " Alex Williamson
2013-10-03 15:38 ` [PULL 1/6] vfio-pci: Add support for MSI affinity Alex Williamson
2013-10-03 15:38   ` [Qemu-devel] " Alex Williamson
2013-10-03 15:38 ` [PULL 2/6] vfio-pci: Test device reset capabilities Alex Williamson
2013-10-03 15:38   ` [Qemu-devel] " Alex Williamson
2013-10-03 15:39 ` [PULL 3/6] vfio-pci: Lazy PCI option ROM loading Alex Williamson
2013-10-03 15:39   ` [Qemu-devel] " Alex Williamson
2013-10-03 18:46   ` Paolo Bonzini
2013-10-03 18:46     ` [Qemu-devel] " Paolo Bonzini
2013-10-03 19:11     ` Alex Williamson
2013-10-03 19:11       ` [Qemu-devel] " Alex Williamson
2013-10-04 12:13   ` Alexey Kardashevskiy
2013-10-04 12:13     ` [Qemu-devel] " Alexey Kardashevskiy
2013-10-04 14:30     ` Alex Williamson
2013-10-04 14:30       ` [Qemu-devel] " Alex Williamson
2013-10-03 15:39 ` [PULL 4/6] vfio-pci: Cleanup error_reports Alex Williamson
2013-10-03 15:39   ` [Qemu-devel] " Alex Williamson
2013-10-03 15:39 ` [PULL 5/6] vfio-pci: Implement PCI hot reset Alex Williamson
2013-10-03 15:39   ` [Qemu-devel] " Alex Williamson
2013-10-03 15:39 ` Alex Williamson [this message]
2013-10-03 15:39   ` [Qemu-devel] [PULL 6/6] vfio: Fix debug output for int128 values Alex Williamson
2013-10-09 14:54 ` [PULL 0/6] VFIO updates for QEMU Anthony Liguori
2013-10-09 14:54   ` [Qemu-devel] " Anthony Liguori
2013-10-09 15:14   ` Alex Williamson
2013-10-09 15:14     ` [Qemu-devel] " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131003153943.26487.458.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.