From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Christoph Baumann <cb-/RsSufbtIHM@public.gmane.org>,
Fabio Estevam <r49496-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Torsten Fleischer
<to-fleischer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org>
Subject: Re: [PATCH 2/3 V3] i2c: mxs: Rework the PIO mode operation
Date: Fri, 4 Oct 2013 07:20:52 +0200 [thread overview]
Message-ID: <20131004052052.GA3194@katana> (raw)
In-Reply-To: <1380497035-7457-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On Mon, Sep 30, 2013 at 01:23:54AM +0200, Marek Vasut wrote:
> Analyze and rework the PIO mode operation. The PIO mode operation
> was unreliable on MX28, by analyzing the bus with LA, the checks
> for when data were available or were to be sent were wrong.
>
> The PIO WRITE has to be completely reworked as it multiple problems.
> The MX23 datasheet helped here, see comments in the code for details.
> The problems boil down to:
> - RUN bit in CTRL0 must be set after DATA register was written
> - The PIO transfer must be 4 bytes long tops, otherwise use
> clock stretching.
> Both of these fixes are implemented.
>
> The PIO READ operation can only be done for up to four bytes as
> we are unable to read out the data from the DATA register fast
> enough.
>
> This patch also tries to document the investigation within the
> code.
>
> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Please fix the checkpatch errors and build warning.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3 V3] i2c: mxs: Rework the PIO mode operation
Date: Fri, 4 Oct 2013 07:20:52 +0200 [thread overview]
Message-ID: <20131004052052.GA3194@katana> (raw)
In-Reply-To: <1380497035-7457-2-git-send-email-marex@denx.de>
On Mon, Sep 30, 2013 at 01:23:54AM +0200, Marek Vasut wrote:
> Analyze and rework the PIO mode operation. The PIO mode operation
> was unreliable on MX28, by analyzing the bus with LA, the checks
> for when data were available or were to be sent were wrong.
>
> The PIO WRITE has to be completely reworked as it multiple problems.
> The MX23 datasheet helped here, see comments in the code for details.
> The problems boil down to:
> - RUN bit in CTRL0 must be set after DATA register was written
> - The PIO transfer must be 4 bytes long tops, otherwise use
> clock stretching.
> Both of these fixes are implemented.
>
> The PIO READ operation can only be done for up to four bytes as
> we are unable to read out the data from the DATA register fast
> enough.
>
> This patch also tries to document the investigation within the
> code.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Please fix the checkpatch errors and build warning.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131004/d076ad12/attachment-0001.sig>
next prev parent reply other threads:[~2013-10-04 5:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 23:23 [PATCH 1/3 V2] i2c: mxs: distinguish i.MX23 and i.MX28 based I2C controller Marek Vasut
2013-09-29 23:23 ` Marek Vasut
[not found] ` <1380497035-7457-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2013-09-29 23:23 ` [PATCH 2/3 V3] i2c: mxs: Rework the PIO mode operation Marek Vasut
2013-09-29 23:23 ` Marek Vasut
[not found] ` <1380497035-7457-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2013-09-30 11:22 ` Wolfram Sang
2013-09-30 11:22 ` Wolfram Sang
2013-09-30 11:38 ` Marek Vasut
2013-09-30 11:38 ` Marek Vasut
[not found] ` <201309301338.27043.marex-ynQEQJNshbs@public.gmane.org>
2013-09-30 11:41 ` Wolfram Sang
2013-09-30 11:41 ` Wolfram Sang
2013-10-04 10:29 ` Marek Vasut
2013-10-04 10:29 ` Marek Vasut
2013-10-04 5:20 ` Wolfram Sang [this message]
2013-10-04 5:20 ` Wolfram Sang
2013-10-06 12:02 ` [PATCH 2/3 V4] " Marek Vasut
2013-10-06 12:02 ` Marek Vasut
[not found] ` <1381060933-11111-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2013-10-06 13:51 ` Wolfram Sang
2013-10-06 13:51 ` Wolfram Sang
2013-10-06 13:54 ` Marek Vasut
2013-10-06 13:54 ` Marek Vasut
2013-09-29 23:23 ` [PATCH 3/3 V3] i2c: mxs: Fix PIO mode on i.MX23 Marek Vasut
2013-09-29 23:23 ` Marek Vasut
2013-10-06 13:54 ` [PATCH 1/3 V2] i2c: mxs: distinguish i.MX23 and i.MX28 based I2C controller Wolfram Sang
2013-10-06 13:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004052052.GA3194@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=cb-/RsSufbtIHM@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=r49496-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=to-fleischer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.