From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org,
Kedareswara rao Appana
<appana.durga.rao-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
Kedareswara rao Appana
<appanad-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation
Date: Fri, 4 Oct 2013 07:46:37 +0200 [thread overview]
Message-ID: <20131004054636.GC3194@katana> (raw)
In-Reply-To: <57a4f5352ce6f03bde7aafe8b880f91b52994379.1380550490.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
> + cr = xiic_getreg32(i2c, XIIC_CR_REG_OFFSET);
> + cr |= XIIC_CR_DIR_IS_TX_MASK;
> + xiic_setreg32(i2c, XIIC_CR_REG_OFFSET, cr);
> +
Is there no need to clear the bit again when receiving? And did
transferring ever work if this bit was never set before?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Kedareswara rao Appana <appana.durga.rao@xilinx.com>,
Kedareswara rao Appana <appanad@xilinx.com>,
Jean Delvare <khali@linux-fr.org>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation
Date: Fri, 4 Oct 2013 07:46:37 +0200 [thread overview]
Message-ID: <20131004054636.GC3194@katana> (raw)
In-Reply-To: <57a4f5352ce6f03bde7aafe8b880f91b52994379.1380550490.git.michal.simek@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
> + cr = xiic_getreg32(i2c, XIIC_CR_REG_OFFSET);
> + cr |= XIIC_CR_DIR_IS_TX_MASK;
> + xiic_setreg32(i2c, XIIC_CR_REG_OFFSET, cr);
> +
Is there no need to clear the bit again when receiving? And did
transferring ever work if this bit was never set before?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-04 5:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 14:15 [PATCH v2 1/3] i2c: xilinx: Fix i2c checkpatch warnings Michal Simek
2013-09-30 14:15 ` Michal Simek
2013-09-30 14:15 ` [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation Michal Simek
[not found] ` <57a4f5352ce6f03bde7aafe8b880f91b52994379.1380550490.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2013-10-04 5:46 ` Wolfram Sang [this message]
2013-10-04 5:46 ` Wolfram Sang
2013-10-04 9:53 ` Michal Simek
2013-10-04 9:53 ` Michal Simek
[not found] ` <524E902D.8030809-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2013-10-04 11:55 ` Wolfram Sang
2013-10-04 11:55 ` Wolfram Sang
2013-10-04 12:12 ` Lars-Peter Clausen
[not found] ` <524EB090.2070708-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-10-04 13:09 ` Michal Simek
2013-10-04 13:09 ` Michal Simek
[not found] ` <524EBDF6.1070605-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2013-10-04 13:38 ` Lars-Peter Clausen
2013-10-04 13:38 ` Lars-Peter Clausen
[not found] ` <524EC4DC.1020708-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-10-04 13:38 ` Michal Simek
2013-10-04 13:38 ` Michal Simek
[not found] ` <524EC4B9.7000202-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2013-10-07 9:19 ` Appana Durga Kedareswara Rao
2013-10-07 9:19 ` Appana Durga Kedareswara Rao
[not found] ` <f3fd6f38d2553e59b077edff1969f4d07f8aa811.1380550490.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2013-09-30 14:15 ` [PATCH v2 3/3] i2c: xilinx: Use devm_* functions Michal Simek
2013-09-30 14:15 ` Michal Simek
[not found] ` <83ec9558211389896f21d9682e9824cd7979466c.1380550490.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2013-10-04 5:33 ` Wolfram Sang
2013-10-04 5:33 ` Wolfram Sang
2013-10-04 9:16 ` Michal Simek
2013-10-04 9:16 ` Michal Simek
2013-10-04 11:58 ` Wolfram Sang
2013-10-04 12:04 ` Michal Simek
2013-10-04 12:04 ` Michal Simek
2013-10-05 5:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004054636.GC3194@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=appana.durga.rao-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=appanad-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.