Re: Commit f7d2c0bb (serial: i.MX: evaluate linux,stdout-path property) and resulting build errors

[Guenter Roeck <linux@roeck-us.net>]

On Sun, Oct 06, 2013 at 01:09:56PM +0200, Sascha Hauer wrote:
> On Thu, Oct 03, 2013 at 11:44:45AM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Oct 02, 2013 at 09:56:11PM -0700, Guenter Roeck wrote:
> > > Hi all,
> > > 
> > > Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a
> > > call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be
> > > built as module, yet add_preferred_console() is not exported on any platform.
> > > This is one reason why arm:allmodconfig fails to build on the upstream kernel.
> > > 
> > > What is the best solution ? Should imx.c not be buildable as module anymore ?
> > 
> > Sascha, I'll have to revert this patch unless you wish to fix it in a
> > different way?
> 
> Do you think exporting add_preferred_console() would be acceptable? If
> yes, that would be my preferred solution.
> 
Difficult to imagine that a console driver can be a loadable module.
Unload it while the system is running and then what ?

Why does this driver have to be buildable as module anyway ? If that is really
a MUST, an alternative might be to only call add_preferred_console() if it is not
built as module.

Guenter