From: Guenter Roeck <linux@roeck-us.net>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: Commit f7d2c0bb (serial: i.MX: evaluate linux,stdout-path property) and resulting build errors
Date: Mon, 07 Oct 2013 03:56:19 -0700 [thread overview]
Message-ID: <52529353.5000600@roeck-us.net> (raw)
In-Reply-To: <20131007064932.GU30088@pengutronix.de>
On 10/06/2013 11:49 PM, Sascha Hauer wrote:
[ ... ]
>
>>From 66197e3bd3d1f4000a637e6960c340d7aa0ccf1f Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Mon, 7 Oct 2013 08:46:46 +0200
> Subject: [PATCH] serial: i.MX: do not allow to build as module
>
> Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a
> call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be
> built as module, yet add_preferred_console() is not exported.
>
> Fix the build failure by disabling module build for the i.MX driver.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index febd45c..b8c5f36 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -551,7 +551,7 @@ config BFIN_UART3_CTSRTS
> Enable hardware flow control in the driver.
>
> config SERIAL_IMX
> - tristate "IMX serial port support"
> + boot "IMX serial port support"
I don't think 'boot' will get you very far unless that is a new config option
I am not aware of :-).
Guenter
next prev parent reply other threads:[~2013-10-07 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 4:56 Commit f7d2c0bb (serial: i.MX: evaluate linux,stdout-path property) and resulting build errors Guenter Roeck
2013-10-03 18:44 ` Greg Kroah-Hartman
2013-10-06 11:09 ` Sascha Hauer
2013-10-06 13:42 ` Greg Kroah-Hartman
2013-10-06 14:37 ` Guenter Roeck
2013-10-06 19:15 ` Greg Kroah-Hartman
2013-10-07 6:49 ` Sascha Hauer
2013-10-07 10:56 ` Guenter Roeck [this message]
2013-10-07 12:31 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52529353.5000600@roeck-us.net \
--to=linux@roeck-us.net \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.