From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] acpi: update win8 OSI blacklist
Date: Sun, 6 Oct 2013 21:59:28 +0100 [thread overview]
Message-ID: <20131006205928.GA20296@srcf.ucam.org> (raw)
In-Reply-To: <CAMP44s0GkVyw+PRYKqq7=MXFFtgUO9xCq6jTsoQV-rSRmC23yg@mail.gmail.com>
On Sun, Oct 06, 2013 at 03:51:05PM -0500, Felipe Contreras wrote:
> On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote:
> >
> >> In case you didn't hear, the plan was to add an entry if a user
> >> reports the backlight not working correctly, and acpi_osi="!Windows
> >> 2012" fixing it with no negative effects. and that's what users did in
> >> bug #60682.
> >
> > So add that to each entry you're adding to the list.
>
> No. These entries are already there, I'm merely updating it. I added a
> comment before the list, but the comment was removed.
There's no point in having a comment that describes a list, because
someone will inevitably reorder them or insert things in between at some
point. Add a comment per entry.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-10-06 20:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 17:13 [PATCH] acpi: update win8 OSI blacklist Felipe Contreras
2013-10-03 17:22 ` Felipe Contreras
[not found] ` <CAANYUdCUg4GM5YX8KkokgqBGaUJjrtcHrkWaQEyhxUcivYnqMQ@mail.gmail.com>
2013-10-19 2:30 ` Felipe Contreras
2013-10-04 16:12 ` Matthew Garrett
2013-10-06 20:29 ` Felipe Contreras
2013-10-06 20:33 ` Matthew Garrett
2013-10-06 20:40 ` Felipe Contreras
2013-10-06 20:45 ` Matthew Garrett
2013-10-06 20:51 ` Felipe Contreras
2013-10-06 20:59 ` Matthew Garrett [this message]
2013-10-06 23:27 ` Felipe Contreras
2013-10-06 23:31 ` Matthew Garrett
2013-10-06 23:36 ` Felipe Contreras
2013-10-06 23:57 ` Matthew Garrett
2013-10-07 0:27 ` Felipe Contreras
2013-10-07 0:32 ` Matthew Garrett
2013-10-07 0:50 ` Felipe Contreras
2013-10-07 0:53 ` Matthew Garrett
2013-10-07 1:01 ` Felipe Contreras
2013-10-07 1:27 ` Matthew Garrett
2013-10-07 1:54 ` Theodore Ts'o
2013-10-07 2:21 ` Felipe Contreras
2013-10-07 2:13 ` Felipe Contreras
2013-10-14 3:30 ` Felipe Contreras
2013-10-14 11:58 ` Rafael J. Wysocki
2013-10-14 13:14 ` Felipe Contreras
2013-10-14 14:16 ` Rafael J. Wysocki
2013-10-14 23:04 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006205928.GA20296@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=felipe.contreras@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.