From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: provide public clk_is_enabled function
Date: Sun, 6 Oct 2013 23:35:36 +0200 [thread overview]
Message-ID: <20131006213536.GC30818@lunn.ch> (raw)
In-Reply-To: <5251E334.2070008@gmail.com>
> Andrew has mentioned, that some bootloaders might disable clocks but
> leave the nodes enabled. Reading those registers would lock up
> the HW, of course. So we thought about to check clk gate status first,
> which this patch is about.
>
> Of course, we can do clk_enable, read, clk_disable as said before - and
> given the amount of questions and misinterpretation, I think it is the
> saner way.
Hi Sebastian
I agree. As you say, too many people have asked questions or
misinterpretation what is happening, so lets go for the simpler method
people can understand.
I would also suggest in the ethernet driver, maybe set_params(), check
if we have a valid MAC address, and if not, issue a warning and call
to eth_hw_addr_random(dev) to get a random one.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: "Mike Turquette" <mturquette@linaro.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Russell King" <linux@arm.linux.org.uk>,
"Jason Cooper" <jason@lakedaemon.net>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
"Grant Likely" <grant.likely@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: provide public clk_is_enabled function
Date: Sun, 6 Oct 2013 23:35:36 +0200 [thread overview]
Message-ID: <20131006213536.GC30818@lunn.ch> (raw)
In-Reply-To: <5251E334.2070008@gmail.com>
> Andrew has mentioned, that some bootloaders might disable clocks but
> leave the nodes enabled. Reading those registers would lock up
> the HW, of course. So we thought about to check clk gate status first,
> which this patch is about.
>
> Of course, we can do clk_enable, read, clk_disable as said before - and
> given the amount of questions and misinterpretation, I think it is the
> saner way.
Hi Sebastian
I agree. As you say, too many people have asked questions or
misinterpretation what is happening, so lets go for the simpler method
people can understand.
I would also suggest in the ethernet driver, maybe set_params(), check
if we have a valid MAC address, and if not, issue a warning and call
to eth_hw_addr_random(dev) to get a random one.
Andrew
next prev parent reply other threads:[~2013-10-06 21:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 10:08 [PATCH] clk: provide public clk_is_enabled function Sebastian Hesselbarth
2013-10-04 10:08 ` Sebastian Hesselbarth
2013-10-04 13:17 ` Andrew Lunn
2013-10-04 13:17 ` Andrew Lunn
2013-10-05 20:24 ` Uwe Kleine-König
2013-10-05 20:24 ` Uwe Kleine-König
2013-10-05 20:42 ` Andrew Lunn
2013-10-05 20:42 ` Andrew Lunn
2013-10-06 9:06 ` Gerhard Sittig
2013-10-06 9:06 ` Gerhard Sittig
2013-10-06 16:30 ` Andrew Lunn
2013-10-06 16:30 ` Andrew Lunn
2013-10-06 19:42 ` Sebastian Hesselbarth
2013-10-06 19:42 ` Sebastian Hesselbarth
2013-10-06 20:02 ` Mike Turquette
2013-10-06 20:02 ` Mike Turquette
2013-10-06 22:24 ` Sebastian Hesselbarth
2013-10-06 22:24 ` Sebastian Hesselbarth
2013-10-06 21:04 ` Mike Turquette
2013-10-06 21:04 ` Mike Turquette
2013-10-07 8:39 ` Sebastian Hesselbarth
2013-10-07 8:39 ` Sebastian Hesselbarth
2013-10-06 21:35 ` Andrew Lunn [this message]
2013-10-06 21:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006213536.GC30818@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.