From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] clk/zynq: Fix possible memory leak
Date: Mon, 7 Oct 2013 05:10:41 +0300 [thread overview]
Message-ID: <20131007021041.GE4875@tarshish> (raw)
In-Reply-To: <1381107317-18120-1-git-send-email-felipensp@gmail.com>
Hi Felipe,
On Sun, Oct 06, 2013 at 09:55:17PM -0300, Felipe Pena wrote:
> The zynq_clk_register_fclk function can leak memory (fclk_lock) when unable
> to alloc memory for fclk_gate_lock
>
> Signed-off-by: Felipe Pena <felipensp@gmail.com>
> ---
> drivers/clk/zynq/clkc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> index cc40fe6..7ea4b5c 100644
> --- a/drivers/clk/zynq/clkc.c
> +++ b/drivers/clk/zynq/clkc.c
> @@ -117,6 +117,7 @@ static void __init zynq_clk_register_fclk(enum zynq_clk fclk,
> goto err;
> fclk_gate_lock = kmalloc(sizeof(*fclk_gate_lock), GFP_KERNEL);
> if (!fclk_gate_lock)
> + kfree(fclk_lock);
> goto err;
Missing braces.
> spin_lock_init(fclk_lock);
> spin_lock_init(fclk_gate_lock);
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Felipe Pena <felipensp@gmail.com>
Cc: "Mike Turquette" <mturquette@linaro.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Stephen Boyd" <sboyd@codeaurora.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] clk/zynq: Fix possible memory leak
Date: Mon, 7 Oct 2013 05:10:41 +0300 [thread overview]
Message-ID: <20131007021041.GE4875@tarshish> (raw)
In-Reply-To: <1381107317-18120-1-git-send-email-felipensp@gmail.com>
Hi Felipe,
On Sun, Oct 06, 2013 at 09:55:17PM -0300, Felipe Pena wrote:
> The zynq_clk_register_fclk function can leak memory (fclk_lock) when unable
> to alloc memory for fclk_gate_lock
>
> Signed-off-by: Felipe Pena <felipensp@gmail.com>
> ---
> drivers/clk/zynq/clkc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> index cc40fe6..7ea4b5c 100644
> --- a/drivers/clk/zynq/clkc.c
> +++ b/drivers/clk/zynq/clkc.c
> @@ -117,6 +117,7 @@ static void __init zynq_clk_register_fclk(enum zynq_clk fclk,
> goto err;
> fclk_gate_lock = kmalloc(sizeof(*fclk_gate_lock), GFP_KERNEL);
> if (!fclk_gate_lock)
> + kfree(fclk_lock);
> goto err;
Missing braces.
> spin_lock_init(fclk_lock);
> spin_lock_init(fclk_gate_lock);
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-10-07 2:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 0:55 [PATCH 1/1] clk/zynq: Fix possible memory leak Felipe Pena
2013-10-07 0:55 ` Felipe Pena
2013-10-07 2:10 ` Baruch Siach [this message]
2013-10-07 2:10 ` Baruch Siach
2013-10-07 16:05 ` Sören Brinkmann
2013-10-07 16:05 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007021041.GE4875@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.