* [PATCH v2] rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice
@ 2013-10-07 7:59 Kevin Lo
2013-10-08 10:46 ` [rt2x00-users] " Stanislaw Gruszka
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Lo @ 2013-10-07 7:59 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, users
In rt2800_config_channel_rf3xxx(), there's no need to toggle
RF R30 bit 7 twice.
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
Changes since v1:
- the previous patch was malformed
---
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
b/drivers/net/wireless/rt2x00/rt2800lib.c
index 25aaa5e..65b4416 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2029,13 +2029,6 @@ static void rt2800_config_channel_rf3xxx(struct
rt2x00_dev *rt2x00dev,
rt2x00dev->default_ant.tx_chain_num <= 2);
rt2800_rfcsr_write(rt2x00dev, 1, rfcsr);
- rt2800_rfcsr_read(rt2x00dev, 30, &rfcsr);
- rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 1);
- rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
- msleep(1);
- rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 0);
- rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
-
rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
rt2x00_set_field8(&rfcsr, RFCSR23_FREQ_OFFSET,
rt2x00dev->freq_offset);
rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [rt2x00-users] [PATCH v2] rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice
2013-10-07 7:59 [PATCH v2] rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice Kevin Lo
@ 2013-10-08 10:46 ` Stanislaw Gruszka
0 siblings, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2013-10-08 10:46 UTC (permalink / raw)
To: Kevin Lo; +Cc: John Linville, linux-wireless, users
On Mon, Oct 07, 2013 at 03:59:44PM +0800, Kevin Lo wrote:
> rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
> rt2x00_set_field8(&rfcsr, RFCSR23_FREQ_OFFSET,
> rt2x00dev->freq_offset);
> rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);
NACK, still malformed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [rt2x00-users] [PATCH v2] rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice
2013-10-07 8:02 Kevin Lo
@ 2013-10-08 10:47 ` Stanislaw Gruszka
0 siblings, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2013-10-08 10:47 UTC (permalink / raw)
To: Kevin Lo; +Cc: John Linville, linux-wireless, users
On Mon, Oct 07, 2013 at 04:02:01PM +0800, Kevin Lo wrote:
> In rt2800_config_channel_rf3xxx(), there's no need to toggle
> RF R30 bit 7 twice.
>
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
This one is fine.
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-08 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-07 7:59 [PATCH v2] rt2x00: rt2800lib: no need to toggle RF R30 bit 7 twice Kevin Lo
2013-10-08 10:46 ` [rt2x00-users] " Stanislaw Gruszka
-- strict thread matches above, loose matches on Subject: below --
2013-10-07 8:02 Kevin Lo
2013-10-08 10:47 ` [rt2x00-users] " Stanislaw Gruszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.