All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <Markos.Chandras@imgtec.com>
Cc: linux-mips@linux-mips.org, Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Subject: Re: [PATCH] MIPS: Print correct PC in trace dump after NMI exception
Date: Tue, 8 Oct 2013 14:38:59 +0200	[thread overview]
Message-ID: <20131008123859.GK1615@linux-mips.org> (raw)
In-Reply-To: <5253FB20.7050909@imgtec.com>

On Tue, Oct 08, 2013 at 01:31:28PM +0100, Markos Chandras wrote:

> >If you were afraid gas might use $1 expanding this macro instruction - no,
> >it won't.  A belt & suspenders approach might be to drop in a ".set noat";
> >it would make the assembler throw an error if should ever see the need to
> >use $1.
> >
> yeah i don't think the assembler would pick $1 in this case but we
> could add ".set noat" just to be safe i suppose.
> 
> Thanks for the review. Could you fix these problems for me or should
> i submit a new patch?

It's trivial enough so I'm going to do it.

The NMI handler btw. was already wrapped with .set push; .set noat; ...
.set pop.

  Ralf

  reply	other threads:[~2013-10-08 12:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 11:39 [PATCH] MIPS: Print correct PC in trace dump after NMI exception Markos Chandras
2013-10-08 11:39 ` Markos Chandras
2013-10-08 11:48 ` thomas.langer
2013-10-08 11:48   ` thomas.langer
2013-10-08 12:21   ` Markos Chandras
2013-10-08 12:21     ` Markos Chandras
2013-10-08 12:29   ` Ralf Baechle
2013-10-08 12:57     ` thomas.langer
2013-10-08 12:57       ` thomas.langer
2013-10-08 12:15 ` Ralf Baechle
2013-10-08 12:31   ` Markos Chandras
2013-10-08 12:31     ` Markos Chandras
2013-10-08 12:38     ` Ralf Baechle [this message]
2013-10-08 12:43       ` Markos Chandras
2013-10-08 12:43         ` Markos Chandras
2013-10-08 12:55         ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131008123859.GK1615@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=Leonid.Yegoshin@imgtec.com \
    --cc=Markos.Chandras@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.