Re: [PATCH] MIPS: Print correct PC in trace dump after NMI exception

[Ralf Baechle <ralf@linux-mips.org>]

On Tue, Oct 08, 2013 at 01:43:40PM +0100, Markos Chandras wrote:

> markos
> 
> On 10/08/13 13:38, Ralf Baechle wrote:
> >On Tue, Oct 08, 2013 at 01:31:28PM +0100, Markos Chandras wrote:
> >
> >>>If you were afraid gas might use $1 expanding this macro instruction - no,
> >>>it won't.  A belt & suspenders approach might be to drop in a ".set noat";
> >>>it would make the assembler throw an error if should ever see the need to
> >>>use $1.
> >>>
> >>yeah i don't think the assembler would pick $1 in this case but we
> >>could add ".set noat" just to be safe i suppose.
> >>
> >>Thanks for the review. Could you fix these problems for me or should
> >>i submit a new patch?
> >
> >It's trivial enough so I'm going to do it.
> >
> >The NMI handler btw. was already wrapped with .set push; .set noat; ...
> >.set pop.
> >
> >   Ralf
> >
> yeah i just noticed. Thank you!

Signature at the top, content at the bottom?  Sigh ...

:-)

I've pushed a fresh upstream-sfr with this patch applied.  This will be
the last change for the day as I want to concentrate on other code.

  Ralf