From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Nishanth Menon" <nm@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>, Felipe <balbi@ti.com>,
"Olof Johansson" <olof@lixom.net>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions
Date: Tue, 8 Oct 2013 12:47:21 -0500 [thread overview]
Message-ID: <20131008174721.GH13128@radagast> (raw)
In-Reply-To: <20131007192009.GA8949@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
Hi,
On Mon, Oct 07, 2013 at 12:20:09PM -0700, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [131007 09:57]:
> > beagle-xm currently would matchup with ti,omap3 which invokes
> > omap3430_init_early instead of omap3630_init_early. So add
> > compatiblity for 3630 to allow match
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> > index 0f7cfc5..2079e22 100644
> > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> > @@ -11,7 +11,7 @@
> >
> > / {
> > model = "TI OMAP3 BeagleBoard xM";
> > - compatible = "ti,omap3-beagle-xm", "ti,omap3-beagle", "ti,omap3";
> > + compatible = "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3-beagle", "ti,omap3";
> >
> > cpus {
> > cpu@0 {
>
> This compatible string looks hacky.. How about just make it
>
> "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3";
>
> How about just leave out "ti,omap3-beagle" here?
ti,omap3-beagle was already part of the original file, we can definitely
remove but I'd expect us to maintain support for that string
indefinitely should anybody continue to use older dtbs.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions
Date: Tue, 8 Oct 2013 12:47:21 -0500 [thread overview]
Message-ID: <20131008174721.GH13128@radagast> (raw)
In-Reply-To: <20131007192009.GA8949@atomide.com>
Hi,
On Mon, Oct 07, 2013 at 12:20:09PM -0700, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [131007 09:57]:
> > beagle-xm currently would matchup with ti,omap3 which invokes
> > omap3430_init_early instead of omap3630_init_early. So add
> > compatiblity for 3630 to allow match
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> > index 0f7cfc5..2079e22 100644
> > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> > @@ -11,7 +11,7 @@
> >
> > / {
> > model = "TI OMAP3 BeagleBoard xM";
> > - compatible = "ti,omap3-beagle-xm", "ti,omap3-beagle", "ti,omap3";
> > + compatible = "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3-beagle", "ti,omap3";
> >
> > cpus {
> > cpu at 0 {
>
> This compatible string looks hacky.. How about just make it
>
> "ti,omap3-beagle-xm", "ti,omap363x", "ti,omap3";
>
> How about just leave out "ti,omap3-beagle" here?
ti,omap3-beagle was already part of the original file, we can definitely
remove but I'd expect us to maintain support for that string
indefinitely should anybody continue to use older dtbs.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131008/618857fb/attachment.sig>
next prev parent reply other threads:[~2013-10-08 17:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 16:08 [RFC PATCH] ARM: OMAP3630: Add generic machine descriptor Nishanth Menon
2013-09-20 16:08 ` Nishanth Menon
2013-09-20 16:08 ` Nishanth Menon
2013-09-20 16:19 ` Olof Johansson
2013-09-20 16:19 ` Olof Johansson
2013-09-20 16:23 ` Felipe Balbi
2013-09-20 16:23 ` Felipe Balbi
2013-09-20 16:23 ` Felipe Balbi
2013-09-20 17:16 ` Olof Johansson
2013-09-20 17:16 ` Olof Johansson
2013-09-20 17:42 ` Felipe Balbi
2013-09-20 17:42 ` Felipe Balbi
2013-09-20 17:42 ` Felipe Balbi
2013-09-20 19:10 ` Nishanth Menon
2013-09-20 19:10 ` Nishanth Menon
2013-09-20 19:10 ` Nishanth Menon
2013-10-07 16:49 ` [PATCH 0/2] ARM: dts: OMAP: standardize SoC specific bindings Nishanth Menon
2013-10-07 16:49 ` Nishanth Menon
2013-10-07 16:49 ` Nishanth Menon
2013-10-07 16:49 ` [PATCH 1/2] Documentation: dt: OMAP: standardize SoC naming definition Nishanth Menon
2013-10-07 16:49 ` Nishanth Menon
2013-10-07 16:49 ` Nishanth Menon
2013-10-07 19:17 ` Tony Lindgren
2013-10-07 19:17 ` Tony Lindgren
2013-10-07 16:49 ` [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions Nishanth Menon
2013-10-07 16:49 ` Nishanth Menon
2013-10-07 16:49 ` Nishanth Menon
2013-10-07 19:20 ` Tony Lindgren
2013-10-07 19:20 ` Tony Lindgren
2013-10-07 20:30 ` [PATCH V2] ARM: OMAP3: Fix hardware detection for omap3630 when booted with device tree Nishanth Menon
2013-10-07 20:30 ` Nishanth Menon
2013-10-07 20:30 ` Nishanth Menon
2013-10-07 20:32 ` Nishanth Menon
2013-10-07 20:32 ` Nishanth Menon
2013-10-07 20:32 ` Nishanth Menon
2013-10-07 20:43 ` [PATCH V3] " Nishanth Menon
2013-10-07 20:43 ` Nishanth Menon
2013-10-07 20:43 ` Nishanth Menon
2013-10-08 0:05 ` Sebastian Reichel
2013-10-08 0:05 ` Sebastian Reichel
2013-10-08 12:00 ` Nishanth Menon
2013-10-08 12:00 ` Nishanth Menon
2013-10-08 17:58 ` Tony Lindgren
2013-10-08 17:58 ` Tony Lindgren
2013-10-08 17:59 ` Nishanth Menon
2013-10-08 17:59 ` Nishanth Menon
2013-10-08 17:47 ` Felipe Balbi [this message]
2013-10-08 17:47 ` [PATCH 2/2] ARM: dts: omap3-beagle: use 3630 definitions Felipe Balbi
2013-10-08 18:01 ` Nishanth Menon
2013-10-08 18:01 ` Nishanth Menon
2013-10-08 18:01 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008174721.GH13128@radagast \
--to=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.