* [PATCH] nft: arp: add parse_target to nft_family_ops_arp
@ 2013-10-06 12:36 Giuseppe Longo
2013-10-07 5:43 ` Tomasz Bursztyka
2013-10-08 19:39 ` Pablo Neira Ayuso
0 siblings, 2 replies; 3+ messages in thread
From: Giuseppe Longo @ 2013-10-06 12:36 UTC (permalink / raw)
To: netfilter-devel; +Cc: Giuseppe Longo
This patch adds parse_target for arp family, fixing segfaults
for xtables-arp -L after rules like:
- xtables-arp -A OUTPUT -o eth0 -j CLASSIFY --set-class 0:7
- xtables-arp -A OUTPUT -o eth1 --h-length 6 -j mangle --mangle-mac-s 01:00:5e:00:01:01
Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
---
iptables/nft-arp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/iptables/nft-arp.c b/iptables/nft-arp.c
index 570962d..08f8814 100644
--- a/iptables/nft-arp.c
+++ b/iptables/nft-arp.c
@@ -643,4 +643,5 @@ struct nft_family_ops nft_family_ops_arp = {
.print_firewall = nft_arp_print_firewall,
.post_parse = NULL,
.rule_find = nft_arp_rule_find,
+ .parse_target = nft_arp_parse_target,
};
--
1.7.8.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nft: arp: add parse_target to nft_family_ops_arp
2013-10-06 12:36 [PATCH] nft: arp: add parse_target to nft_family_ops_arp Giuseppe Longo
@ 2013-10-07 5:43 ` Tomasz Bursztyka
2013-10-08 19:39 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Tomasz Bursztyka @ 2013-10-07 5:43 UTC (permalink / raw)
To: Giuseppe Longo, netfilter-devel
Good catch!
I probably read that file dozens of time and did not spot this...
Thanks,
Tomasz
> This patch adds parse_target for arp family, fixing segfaults
> for xtables-arp -L after rules like:
>
> - xtables-arp -A OUTPUT -o eth0 -j CLASSIFY --set-class 0:7
> - xtables-arp -A OUTPUT -o eth1 --h-length 6 -j mangle --mangle-mac-s 01:00:5e:00:01:01
>
> Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
> ---
> iptables/nft-arp.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/iptables/nft-arp.c b/iptables/nft-arp.c
> index 570962d..08f8814 100644
> --- a/iptables/nft-arp.c
> +++ b/iptables/nft-arp.c
> @@ -643,4 +643,5 @@ struct nft_family_ops nft_family_ops_arp = {
> .print_firewall = nft_arp_print_firewall,
> .post_parse = NULL,
> .rule_find = nft_arp_rule_find,
> + .parse_target = nft_arp_parse_target,
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nft: arp: add parse_target to nft_family_ops_arp
2013-10-06 12:36 [PATCH] nft: arp: add parse_target to nft_family_ops_arp Giuseppe Longo
2013-10-07 5:43 ` Tomasz Bursztyka
@ 2013-10-08 19:39 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2013-10-08 19:39 UTC (permalink / raw)
To: Giuseppe Longo; +Cc: netfilter-devel
On Sun, Oct 06, 2013 at 02:36:47PM +0200, Giuseppe Longo wrote:
> This patch adds parse_target for arp family, fixing segfaults
> for xtables-arp -L after rules like:
>
> - xtables-arp -A OUTPUT -o eth0 -j CLASSIFY --set-class 0:7
> - xtables-arp -A OUTPUT -o eth1 --h-length 6 -j mangle --mangle-mac-s 01:00:5e:00:01:01
Applied, thanks Giuseppe.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-08 19:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-06 12:36 [PATCH] nft: arp: add parse_target to nft_family_ops_arp Giuseppe Longo
2013-10-07 5:43 ` Tomasz Bursztyka
2013-10-08 19:39 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.