All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guillaume CLÉMENT" <gclement@baobob.org>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers
Date: Tue, 8 Oct 2013 22:31:53 +0200	[thread overview]
Message-ID: <20131008203148.GA1902@thor.baobob.org> (raw)
In-Reply-To: <20131008195754.GA2010@thor.baobob.org>

> This is quite late to report, but I've just begun testing 3.12, and this
> patch makes my screen garbled when using the modesetting xorg driver.
>

Alright, after trying to notice what was different between the old and
new code, I've found the culprit :

-   gt->npage = pages;

There is no equivalent of this line with the new code. This must mess
things up.


By writing:

   gt->npage = gt->gem.size / PAGE_SIZE;

after:
   gt->npage = pages;

I don't experience the problem anymore. If this looks good to you, I'll
create a patch for this.



Thanks,

- Guillaume

  parent reply	other threads:[~2013-10-08 20:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 17:41 [PATCH 0/9] deps for msm drm (flip-work helper, const ioctl table, and gem helpers) Rob Clark
2013-08-07 17:41 ` [PATCH 1/9] drm: add flip-work helper Rob Clark
2013-08-07 17:49   ` Daniel Vetter
2013-08-07 18:20     ` Rob Clark
2013-08-07 18:41       ` Rob Clark
2013-08-07 17:41 ` [PATCH 2/9] drm/tilcdc: use " Rob Clark
2013-08-07 17:41 ` [PATCH 3/9] drm/omap: " Rob Clark
2013-08-07 17:41 ` [PATCH 4/9] drm: const'ify ioctls table (v2) Rob Clark
2013-08-07 17:48   ` Rob Clark
2013-08-07 17:41 ` [PATCH 5/9] drm/gem: add drm_gem_create_mmap_offset_size() Rob Clark
2013-08-08 15:29   ` David Herrmann
2013-08-07 17:41 ` [PATCH 6/9] drm/gem: add shmem get/put page helpers Rob Clark
2013-08-07 17:41 ` [PATCH 7/9] drm/gma500: use gem " Rob Clark
2013-10-08 19:57   ` Guillaume CLÉMENT
2013-10-08 20:19     ` Rob Clark
2013-10-08 20:22       ` Patrik Jakobsson
2013-10-08 20:31     ` Guillaume CLÉMENT [this message]
2013-08-07 17:41 ` [PATCH 8/9] drm/udl: " Rob Clark
2013-08-07 17:41 ` [PATCH 9/9] drm/omap: kill omap_gem_helpers.c Rob Clark
2013-08-07 20:13   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131008203148.GA1902@thor.baobob.org \
    --to=gclement@baobob.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.