From: Tony Lindgren <tony@atomide.com>
To: Sricharan R <r.sricharan@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
santosh.shilimkar@ti.com, rnayak@ti.com, nm@ti.com,
marc.zyngier@arm.com, mark.rutland@arm.com
Subject: Re: [PATCH V4] ARM: OMAP5/DRA7: realtime_counter: Configure CNTFRQ register
Date: Tue, 8 Oct 2013 14:45:23 -0700 [thread overview]
Message-ID: <20131008214523.GU8313@atomide.com> (raw)
In-Reply-To: <524D44B9.30208@ti.com>
* Sricharan R <r.sricharan@ti.com> [131003 03:27]:
> On Wednesday 18 September 2013 09:32 PM, Sricharan R wrote:
> > --- a/arch/arm/boot/dts/omap5.dtsi
> > +++ b/arch/arm/boot/dts/omap5.dtsi
> > @@ -52,7 +52,6 @@
> > <GIC_PPI 14 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>,
> > <GIC_PPI 11 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>,
> > <GIC_PPI 10 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>;
> > - clock-frequency = <6144000>;
> > };
> >
> > gic: interrupt-controller@48211000 {
Can the above be done later on in a separate clean-up patch?
If so I can drop that part as that removes a dependency to the
.dts patches queued by Benoit.
> > --- a/arch/arm/mach-omap2/omap-smp.c
> > +++ b/arch/arm/mach-omap2/omap-smp.c
> > @@ -41,6 +41,8 @@
> >
> > u16 pm44xx_errata;
> >
> > +extern unsigned long arch_timer_freq;
> > +
> > /* SCU base address */
> > static void __iomem *scu_base;
> >
No externs in *.c files please, checkpatch.pl and sparse should warn
about this.
> Are you planning to pull this patch and the below $subject patch as well? They are
> acked and tested.
>
> ARM: DRA7: realtime_counter: Add ratio registers for 20MHZ sys-clk frequency
>
> http://www.spinics.net/lists/linux-omap/msg97281.html
The 20MHz patch I've applied, just noticed the above things
when was about to apply this.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4] ARM: OMAP5/DRA7: realtime_counter: Configure CNTFRQ register
Date: Tue, 8 Oct 2013 14:45:23 -0700 [thread overview]
Message-ID: <20131008214523.GU8313@atomide.com> (raw)
In-Reply-To: <524D44B9.30208@ti.com>
* Sricharan R <r.sricharan@ti.com> [131003 03:27]:
> On Wednesday 18 September 2013 09:32 PM, Sricharan R wrote:
> > --- a/arch/arm/boot/dts/omap5.dtsi
> > +++ b/arch/arm/boot/dts/omap5.dtsi
> > @@ -52,7 +52,6 @@
> > <GIC_PPI 14 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>,
> > <GIC_PPI 11 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>,
> > <GIC_PPI 10 (GIC_CPU_MASK_RAW(3) | IRQ_TYPE_LEVEL_LOW)>;
> > - clock-frequency = <6144000>;
> > };
> >
> > gic: interrupt-controller at 48211000 {
Can the above be done later on in a separate clean-up patch?
If so I can drop that part as that removes a dependency to the
.dts patches queued by Benoit.
> > --- a/arch/arm/mach-omap2/omap-smp.c
> > +++ b/arch/arm/mach-omap2/omap-smp.c
> > @@ -41,6 +41,8 @@
> >
> > u16 pm44xx_errata;
> >
> > +extern unsigned long arch_timer_freq;
> > +
> > /* SCU base address */
> > static void __iomem *scu_base;
> >
No externs in *.c files please, checkpatch.pl and sparse should warn
about this.
> Are you planning to pull this patch and the below $subject patch as well? They are
> acked and tested.
>
> ARM: DRA7: realtime_counter: Add ratio registers for 20MHZ sys-clk frequency
>
> http://www.spinics.net/lists/linux-omap/msg97281.html
The 20MHz patch I've applied, just noticed the above things
when was about to apply this.
Regards,
Tony
next prev parent reply other threads:[~2013-10-08 21:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 16:02 [PATCH V4] ARM: OMAP5/DRA7: realtime_counter: Configure CNTFRQ register Sricharan R
2013-09-18 16:02 ` Sricharan R
2013-10-03 10:19 ` Sricharan R
2013-10-03 10:19 ` Sricharan R
2013-10-08 21:45 ` Tony Lindgren [this message]
2013-10-08 21:45 ` Tony Lindgren
2013-10-08 22:05 ` Santosh Shilimkar
2013-10-08 22:05 ` Santosh Shilimkar
2013-10-09 13:15 ` Sricharan R
2013-10-09 13:15 ` Sricharan R
2013-10-09 13:16 ` Sricharan R
2013-10-09 13:16 ` Sricharan R
2013-10-09 13:18 ` Santosh Shilimkar
2013-10-09 13:18 ` Santosh Shilimkar
2013-10-09 13:17 ` Santosh Shilimkar
2013-10-09 13:17 ` Santosh Shilimkar
2013-10-09 13:20 ` Sricharan R
2013-10-09 13:20 ` Sricharan R
2013-10-09 13:23 ` Santosh Shilimkar
2013-10-09 13:23 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008214523.GU8313@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=r.sricharan@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.