From: Jonathan Nieder <jrnieder@gmail.com>
To: Paolo Giarrusso <p.giarrusso@gmail.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
"David A. Greene" <greened@obbligato.org>
Subject: Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly
Date: Wed, 9 Oct 2013 14:11:01 -0700 [thread overview]
Message-ID: <20131009211101.GM9464@google.com> (raw)
In-Reply-To: <CAAcnjCQ+c=8wYZkqS7VzZ_bDDDkSwdQ3qdz77osrSpKDS9ON7Q@mail.gmail.com>
Paolo Giarrusso wrote:
> Seeing the email, I wonder whether there's hope something like that
> can be preserved in an email, and whether the code should use some
> escape sequence instead.
Yes, please. Mind if I amend it to
printf "%s\r" "$revcount/$revmax ($createcount)" >&2
?
[...]
>> say()
>> {
>> if [ -z "$quiet" ]; then
>> echo "$@" >&2
>> fi
>> }
I agree with the other reviewers that this should be fixed to use
printf, too, but that's another topic.
Thanks,
Jonathan
next prev parent reply other threads:[~2013-10-09 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 3:57 [PATCH] git-subtree: Avoid using echo -n even indirectly Paolo G. Giarrusso
2013-10-09 10:20 ` Tay Ray Chuan
[not found] ` <CAAcnjCT1bdR+9kDW=q_326OhiSMm3_j-yOh0-ayTkObK3bZ3bQ@mail.gmail.com>
2013-10-09 10:32 ` Fwd: " Paolo Giarrusso
2013-10-09 10:46 ` Johannes Sixt
2013-10-09 11:26 ` Matthieu Moy
2013-10-09 12:03 ` Paolo Giarrusso
2013-10-09 19:48 ` Jeff King
2013-10-09 21:11 ` Jonathan Nieder [this message]
2013-10-11 9:32 ` Paolo Giarrusso
-- strict thread matches above, loose matches on Subject: below --
2013-10-28 14:04 Paolo Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009211101.GM9464@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=greened@obbligato.org \
--cc=p.giarrusso@gmail.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.