From: Johannes Sixt <j.sixt@viscovery.net>
To: Paolo Giarrusso <p.giarrusso@gmail.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly
Date: Wed, 09 Oct 2013 12:46:47 +0200 [thread overview]
Message-ID: <52553417.2090903@viscovery.net> (raw)
In-Reply-To: <CAAcnjCQ+c=8wYZkqS7VzZ_bDDDkSwdQ3qdz77osrSpKDS9ON7Q@mail.gmail.com>
Am 10/9/2013 12:32, schrieb Paolo Giarrusso:
> On Wed, Oct 9, 2013 at 12:20 PM, Tay Ray Chuan <rctay89@gmail.com> wrote:
>> On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso
>> <p.giarrusso@gmail.com> wrote:
>>> diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
>>> index 7d7af03..ebfb78f 100755
>>> --- a/contrib/subtree/git-subtree.sh
>>> +++ b/contrib/subtree/git-subtree.sh
>>> @@ -592,7 +592,9 @@ cmd_split()
>>> eval "$grl" |
>>> while read rev parents; do
>>> revcount=$(($revcount + 1))
>>> - say -n "$revcount/$revmax ($createcount)
>>> "
>>> + if [ -z "$quiet" ]; then
>>> + printf "%s" "$revcount/$revmax ($createcount)
>>> " >&2
>
> An additional note for reviewers and appliers: the original and the
> patched codeboth embed a literal ^M,
>...
> whether the code should use some
> escape sequence instead.
As you are using printf, you can easily do:
printf '%s\r' "..."
without using ^M.
-- Hannes
next prev parent reply other threads:[~2013-10-09 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 3:57 [PATCH] git-subtree: Avoid using echo -n even indirectly Paolo G. Giarrusso
2013-10-09 10:20 ` Tay Ray Chuan
[not found] ` <CAAcnjCT1bdR+9kDW=q_326OhiSMm3_j-yOh0-ayTkObK3bZ3bQ@mail.gmail.com>
2013-10-09 10:32 ` Fwd: " Paolo Giarrusso
2013-10-09 10:46 ` Johannes Sixt [this message]
2013-10-09 11:26 ` Matthieu Moy
2013-10-09 12:03 ` Paolo Giarrusso
2013-10-09 19:48 ` Jeff King
2013-10-09 21:11 ` Jonathan Nieder
2013-10-11 9:32 ` Paolo Giarrusso
-- strict thread matches above, loose matches on Subject: below --
2013-10-28 14:04 Paolo Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52553417.2090903@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=p.giarrusso@gmail.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.