All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Andreas Larsson <andreas@gaisler.com>
Cc: balbi@ti.com, linux-usb@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	software@gaisler.com
Subject: Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC
Date: Thu, 10 Oct 2013 10:38:51 -0500	[thread overview]
Message-ID: <20131010153851.GJ28375@radagast> (raw)
In-Reply-To: <524BDEB6.8060404@gaisler.com>

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

Hi,

On Wed, Oct 02, 2013 at 10:52:06AM +0200, Andreas Larsson wrote:
> >hmm, there are two ways to look at this.
> >
> >a) we have KERN_CONT to continue printing messages
> >b) you might prefer using debugfs and seq_puts() for dumping large(-ish)
> >amounts of debugging data ;-)
> 
> I just found print_hex_dump_debug that takes care of everything
> including dynamic debug support, so I'll use that.

fair enough, although it's a little odd to have that always in the
driver. As long as it's hidden under VERBOSE_DEBUG I guess we can accept
it.

thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Andreas Larsson <andreas@gaisler.com>
Cc: <balbi@ti.com>, <linux-usb@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<software@gaisler.com>
Subject: Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC
Date: Thu, 10 Oct 2013 10:38:51 -0500	[thread overview]
Message-ID: <20131010153851.GJ28375@radagast> (raw)
In-Reply-To: <524BDEB6.8060404@gaisler.com>

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

Hi,

On Wed, Oct 02, 2013 at 10:52:06AM +0200, Andreas Larsson wrote:
> >hmm, there are two ways to look at this.
> >
> >a) we have KERN_CONT to continue printing messages
> >b) you might prefer using debugfs and seq_puts() for dumping large(-ish)
> >amounts of debugging data ;-)
> 
> I just found print_hex_dump_debug that takes care of everything
> including dynamic debug support, so I'll use that.

fair enough, although it's a little odd to have that always in the
driver. As long as it's hidden under VERBOSE_DEBUG I guess we can accept
it.

thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-10-10 15:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 14:05 [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC Andreas Larsson
2013-08-28  9:02 ` Andreas Larsson
     [not found]   ` <521DBC9E.9080001-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
2013-09-09  5:33     ` Andreas Larsson
2013-09-09  5:33       ` Andreas Larsson
2013-09-09 15:24       ` Greg Kroah-Hartman
     [not found]         ` <20130909152424.GA26404-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-09-18  1:46           ` Felipe Balbi
2013-09-18  1:46             ` Felipe Balbi
2013-09-18 17:15 ` Felipe Balbi
2013-09-18 17:15   ` Felipe Balbi
2013-10-01  8:34   ` Andreas Larsson
2013-10-01 14:19     ` Felipe Balbi
2013-10-01 14:19       ` Felipe Balbi
2013-10-02  8:52       ` Andreas Larsson
2013-10-02  8:52         ` Andreas Larsson
2013-10-10 15:38         ` Felipe Balbi [this message]
2013-10-10 15:38           ` Felipe Balbi
2013-10-28 12:59       ` Andreas Larsson
2013-11-26 17:43         ` Felipe Balbi
2013-11-26 17:43           ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010153851.GJ28375@radagast \
    --to=balbi@ti.com \
    --cc=andreas@gaisler.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=software@gaisler.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.