From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Matt Fleming
<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support
Date: Thu, 10 Oct 2013 13:37:10 -0400 [thread overview]
Message-ID: <20131010173710.GA18821@fenchurch.internal.datastacks.com> (raw)
In-Reply-To: <20131010172844.GA26430-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thu, Oct 10, 2013 at 07:28:44PM +0200, Ingo Molnar wrote:
>
> Is a non-32-bit framebuffer a possibility? If yes then it might be nice to
> emit an informative printk() here, so that users who try to enable EFI
> early-printk can at least see why it's not working. (Assuming they get to
> look at regular printk output, on a safe/working kernel.)
Not really - the spec allows RGBx, BGRx, and for custom bit masks, but
they're define like:
typedef struct {
UINT32 RedMask;
UINT32 GreenMask;
UINT32 BlueMask;
UINT32 ReservedMask;
} EFI_PIXEL_BITMASK;
--
Peter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Jones <pjones@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Matt Fleming <matt@console-pimps.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support
Date: Thu, 10 Oct 2013 13:37:10 -0400 [thread overview]
Message-ID: <20131010173710.GA18821@fenchurch.internal.datastacks.com> (raw)
In-Reply-To: <20131010172844.GA26430@gmail.com>
On Thu, Oct 10, 2013 at 07:28:44PM +0200, Ingo Molnar wrote:
>
> Is a non-32-bit framebuffer a possibility? If yes then it might be nice to
> emit an informative printk() here, so that users who try to enable EFI
> early-printk can at least see why it's not working. (Assuming they get to
> look at regular printk output, on a safe/working kernel.)
Not really - the spec allows RGBx, BGRx, and for custom bit masks, but
they're define like:
typedef struct {
UINT32 RedMask;
UINT32 GreenMask;
UINT32 BlueMask;
UINT32 ReservedMask;
} EFI_PIXEL_BITMASK;
--
Peter
next prev parent reply other threads:[~2013-10-10 17:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 16:41 [PATCH] x86/efi: Add EFI framebuffer earlyprintk support Matt Fleming
2013-10-10 16:41 ` Matt Fleming
[not found] ` <1381423261-30566-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-10 17:28 ` Ingo Molnar
2013-10-10 17:28 ` Ingo Molnar
[not found] ` <20131010172844.GA26430-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-10 17:37 ` Peter Jones [this message]
2013-10-10 17:37 ` Peter Jones
2013-10-10 17:45 ` Ingo Molnar
[not found] ` <20131010174521.GA27218-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-10 17:58 ` Matthew Garrett
2013-10-10 17:58 ` Matthew Garrett
[not found] ` <20131010175828.GA9065-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-10-11 6:21 ` Ingo Molnar
2013-10-11 6:21 ` Ingo Molnar
2013-10-10 18:09 ` Peter Jones
[not found] ` <20131010180937.GD18821-FS9oOTXHwv9t4tGkRPVz9tcb/sdHg95EuydrBrBl+0sAvxtiuMwx3w@public.gmane.org>
2013-10-11 7:08 ` Geert Uytterhoeven
2013-10-11 7:08 ` Geert Uytterhoeven
2013-10-11 14:00 ` Matt Fleming
2013-10-11 14:00 ` Matt Fleming
[not found] ` <20131011140039.GF12321-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-12 17:49 ` Ingo Molnar
2013-10-12 17:49 ` Ingo Molnar
[not found] ` <20131012174934.GA18849-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-13 20:47 ` H. Peter Anvin
2013-10-13 20:47 ` H. Peter Anvin
[not found] ` <525B06CB.6090602-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-10-14 7:57 ` Ingo Molnar
2013-10-14 7:57 ` Ingo Molnar
[not found] ` <20131014075726.GB20435-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-16 9:16 ` Matt Fleming
2013-10-16 9:16 ` Matt Fleming
[not found] ` <20131016091648.GD10834-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-16 9:27 ` Ingo Molnar
2013-10-16 9:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010173710.GA18821@fenchurch.internal.datastacks.com \
--to=pjones-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.