* [PATCH] Fix for bcache regression
@ 2013-10-11 0:31 Kent Overstreet
2013-10-11 0:31 ` [PATCH] bcache: Fix a null ptr deref regression Kent Overstreet
[not found] ` <1381451475-24551-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
0 siblings, 2 replies; 6+ messages in thread
From: Kent Overstreet @ 2013-10-11 0:31 UTC (permalink / raw)
To: torvalds, axboe; +Cc: linux-kernel, linux-bcache
Linus, please apply - the last fix in the bugfix series I sent you had an
embarassing screwup...
For 3.13, shall I start sending you pull requests directly?
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] bcache: Fix a null ptr deref regression
2013-10-11 0:31 [PATCH] Fix for bcache regression Kent Overstreet
@ 2013-10-11 0:31 ` Kent Overstreet
[not found] ` <1381451475-24551-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
1 sibling, 0 replies; 6+ messages in thread
From: Kent Overstreet @ 2013-10-11 0:31 UTC (permalink / raw)
To: torvalds, axboe; +Cc: linux-kernel, linux-bcache, Kent Overstreet
c0f04d8 was fixing a reported data corruption bug, but it seems some
last minute refactoring or rebasing introduced a null pointer deref.
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Cc: linux-stable <stable@vger.kernel.org> # >= v3.10
Reported-by: Gabriel de Perthuis <g2p.code@gmail.com>
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index 71eb233..b6a74bc 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -996,6 +996,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
closure_bio_submit(bio, cl, s->d);
} else {
bch_writeback_add(dc);
+ s->op.cache_bio = bio;
if (bio->bi_rw & REQ_FLUSH) {
/* Also need to send a flush to the backing device */
@@ -1008,8 +1009,6 @@ static void request_write(struct cached_dev *dc, struct search *s)
flush->bi_private = cl;
closure_bio_submit(flush, cl, s->d);
- } else {
- s->op.cache_bio = bio;
}
}
out:
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1381451475-24551-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>]
* Re: [PATCH] Fix for bcache regression
2013-10-11 0:31 [PATCH] Fix for bcache regression Kent Overstreet
@ 2013-10-11 2:23 ` Jens Axboe
[not found] ` <1381451475-24551-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2013-10-11 2:23 UTC (permalink / raw)
To: Kent Overstreet
Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-bcache-u79uwXL29TY76Z2rM5mHXA
On Thu, Oct 10 2013, Kent Overstreet wrote:
> Linus, please apply - the last fix in the bugfix series I sent you had an
> embarassing screwup...
>
> For 3.13, shall I start sending you pull requests directly?
Sorry I dropped the ball on that one, it's the first time ever I've
missed a deadline. It's being ramped up again, kernel time will be
plenty again shortly.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Fix for bcache regression
@ 2013-10-11 2:23 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2013-10-11 2:23 UTC (permalink / raw)
To: Kent Overstreet; +Cc: torvalds, linux-kernel, linux-bcache
On Thu, Oct 10 2013, Kent Overstreet wrote:
> Linus, please apply - the last fix in the bugfix series I sent you had an
> embarassing screwup...
>
> For 3.13, shall I start sending you pull requests directly?
Sorry I dropped the ball on that one, it's the first time ever I've
missed a deadline. It's being ramped up again, kernel time will be
plenty again shortly.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20131011022313.GA31029-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>]
* Re: [PATCH] Fix for bcache regression
2013-10-11 2:23 ` Jens Axboe
@ 2013-10-11 2:38 ` Kent Overstreet
-1 siblings, 0 replies; 6+ messages in thread
From: Kent Overstreet @ 2013-10-11 2:38 UTC (permalink / raw)
To: Jens Axboe
Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-bcache-u79uwXL29TY76Z2rM5mHXA
On Thu, Oct 10, 2013 at 08:23:13PM -0600, Jens Axboe wrote:
> On Thu, Oct 10 2013, Kent Overstreet wrote:
> > Linus, please apply - the last fix in the bugfix series I sent you had an
> > embarassing screwup...
> >
> > For 3.13, shall I start sending you pull requests directly?
>
> Sorry I dropped the ball on that one, it's the first time ever I've
> missed a deadline. It's being ramped up again, kernel time will be
> plenty again shortly.
No worries, I've been behind on plenty of stuff too and wouldn't have
much room to complain :)
Probably best that the giant pull ended up waiting a bit longer anyways
with the bugs I've still been fixing. Anyways, bcache is self contained
enough I doubt it really matters, so whatever the two of you prefer is
fine by me.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix for bcache regression
@ 2013-10-11 2:38 ` Kent Overstreet
0 siblings, 0 replies; 6+ messages in thread
From: Kent Overstreet @ 2013-10-11 2:38 UTC (permalink / raw)
To: Jens Axboe; +Cc: torvalds, linux-kernel, linux-bcache
On Thu, Oct 10, 2013 at 08:23:13PM -0600, Jens Axboe wrote:
> On Thu, Oct 10 2013, Kent Overstreet wrote:
> > Linus, please apply - the last fix in the bugfix series I sent you had an
> > embarassing screwup...
> >
> > For 3.13, shall I start sending you pull requests directly?
>
> Sorry I dropped the ball on that one, it's the first time ever I've
> missed a deadline. It's being ramped up again, kernel time will be
> plenty again shortly.
No worries, I've been behind on plenty of stuff too and wouldn't have
much room to complain :)
Probably best that the giant pull ended up waiting a bit longer anyways
with the bugs I've still been fixing. Anyways, bcache is self contained
enough I doubt it really matters, so whatever the two of you prefer is
fine by me.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-11 2:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11 0:31 [PATCH] Fix for bcache regression Kent Overstreet
2013-10-11 0:31 ` [PATCH] bcache: Fix a null ptr deref regression Kent Overstreet
[not found] ` <1381451475-24551-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
2013-10-11 2:23 ` [PATCH] Fix for bcache regression Jens Axboe
2013-10-11 2:23 ` Jens Axboe
[not found] ` <20131011022313.GA31029-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2013-10-11 2:38 ` Kent Overstreet
2013-10-11 2:38 ` Kent Overstreet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.