From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Weijie Yang <weijie.yang@samsung.com>,
sjenning@linux.vnet.ibm.com, bob.liu@oracle.com,
weijie.yang.kh@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
d.j.shin@samsung.com, heesub.shin@samsung.com,
kyungmin.park@samsung.com, hau.chen@samsung.com,
bifeng.tong@samsung.com, rui.xie@samsung.com
Subject: Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning
Date: Fri, 11 Oct 2013 16:14:30 +0900 [thread overview]
Message-ID: <20131011071430.GD6847@bbox> (raw)
In-Reply-To: <20131010125506.158c871becad30328abf6838@linux-foundation.org>
On Thu, Oct 10, 2013 at 12:55:06PM -0700, Andrew Morton wrote:
> On Mon, 23 Sep 2013 16:21:49 +0800 Weijie Yang <weijie.yang@samsung.com> wrote:
>
> > add SetPageReclaim before __swap_writepage so that page can be moved to the
> > tail of the inactive list, which can avoid unnecessary page scanning as this
> > page was reclaimed by swap subsystem before.
> >
> > Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> > Reviewed-by: Bob Liu <bob.liu@oracle.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: stable@vger.kernel.org
> > Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>
> As a minor(?) performance tweak, I don't believe this is suitable for
> -stable backporting, so I took that out. If you believe this was a
> mistake, please explain why.
>
Yes. It's never stable stuff.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Weijie Yang <weijie.yang@samsung.com>,
sjenning@linux.vnet.ibm.com, bob.liu@oracle.com,
weijie.yang.kh@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
d.j.shin@samsung.com, heesub.shin@samsung.com,
kyungmin.park@samsung.com, hau.chen@samsung.com,
bifeng.tong@samsung.com, rui.xie@samsung.com
Subject: Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning
Date: Fri, 11 Oct 2013 16:14:30 +0900 [thread overview]
Message-ID: <20131011071430.GD6847@bbox> (raw)
In-Reply-To: <20131010125506.158c871becad30328abf6838@linux-foundation.org>
On Thu, Oct 10, 2013 at 12:55:06PM -0700, Andrew Morton wrote:
> On Mon, 23 Sep 2013 16:21:49 +0800 Weijie Yang <weijie.yang@samsung.com> wrote:
>
> > add SetPageReclaim before __swap_writepage so that page can be moved to the
> > tail of the inactive list, which can avoid unnecessary page scanning as this
> > page was reclaimed by swap subsystem before.
> >
> > Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> > Reviewed-by: Bob Liu <bob.liu@oracle.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: stable@vger.kernel.org
> > Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>
> As a minor(?) performance tweak, I don't believe this is suitable for
> -stable backporting, so I took that out. If you believe this was a
> mistake, please explain why.
>
Yes. It's never stable stuff.
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2013-10-11 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 8:21 [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning Weijie Yang
2013-09-23 8:21 ` Weijie Yang
2013-09-24 1:03 ` Minchan Kim
2013-09-24 1:03 ` Minchan Kim
2013-10-10 19:55 ` Andrew Morton
2013-10-10 19:55 ` Andrew Morton
2013-10-11 7:14 ` Minchan Kim [this message]
2013-10-11 7:14 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011071430.GD6847@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bifeng.tong@samsung.com \
--cc=bob.liu@oracle.com \
--cc=d.j.shin@samsung.com \
--cc=hau.chen@samsung.com \
--cc=heesub.shin@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rui.xie@samsung.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=weijie.yang.kh@gmail.com \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.