From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: peterz@infradead.org, fweisbec@gmail.com, dhowells@redhat.com,
edumazet@google.com, gaofeng@cn.fujitsu.com, mingo@kernel.org,
bridge@lists.linux-foundation.org, jmorris@namei.org,
dipankar@in.ibm.com, darren@dvhart.com, rostedt@goodmis.org,
niv@us.ibm.com, mathieu.desnoyers@efficios.com,
kuznet@ms2.inr.ac.ru, tglx@linutronix.de,
johannes@sipsolutions.net, laijs@cn.fujitsu.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-decnet-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kaber@trash.net,
stephen@networkplumber.org, sbw@mit.edu, tgraf@suug.ch,
akpm@linux-foundation.org, fengguang.wu@intel.com,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13
Date: Sat, 12 Oct 2013 10:13:45 -0700 [thread overview]
Message-ID: <20131012171345.GB5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131012065326.GG15339@leaf>
On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote:
> On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote:
> > Changes from v2:
> >
> > o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
> > the pointers are all --rcu and already visible to readers,
> > as suggested by Eric Dumazet and Josh Triplett.
>
> Hang on a moment. Do *none* of these cases need write memory barriers?
Sigh. Some afternoons it doesn't pay to touch the keyboard.
Thank you for catching this. I will fix, but at this point, I am thinking
in terms of 3.14 rather than 3.13 for this series.
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu,
fengguang.wu@intel.com, stephen@networkplumber.org,
davem@davemloft.net, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, tgraf@suug.ch, gaofeng@cn.fujitsu.com,
linux-decnet-user@lists.sourceforge.net, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
linville@tuxdriver.com, johannes@sipsolutions.net
Subject: Re: [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13
Date: Sat, 12 Oct 2013 10:13:45 -0700 [thread overview]
Message-ID: <20131012171345.GB5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131012065326.GG15339@leaf>
On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote:
> On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote:
> > Changes from v2:
> >
> > o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
> > the pointers are all --rcu and already visible to readers,
> > as suggested by Eric Dumazet and Josh Triplett.
>
> Hang on a moment. Do *none* of these cases need write memory barriers?
Sigh. Some afternoons it doesn't pay to touch the keyboard.
Thank you for catching this. I will fix, but at this point, I am thinking
in terms of 3.14 rather than 3.13 for this series.
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: peterz@infradead.org, fweisbec@gmail.com, dhowells@redhat.com,
edumazet@google.com, gaofeng@cn.fujitsu.com, mingo@kernel.org,
bridge@lists.linux-foundation.org, jmorris@namei.org,
dipankar@in.ibm.com, darren@dvhart.com, rostedt@goodmis.org,
niv@us.ibm.com, mathieu.desnoyers@efficios.com,
kuznet@ms2.inr.ac.ru, tglx@linutronix.de,
johannes@sipsolutions.net, laijs@cn.fujitsu.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-decnet-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kaber@trash.net,
stephen@networkplumber.org, sbw@mit.edu, tgraf@suug.ch,
akpm@linux-foundation.org, fengguang.wu@intel.com,
davem@davemloft.net
Subject: Re: [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13
Date: Sat, 12 Oct 2013 10:13:45 -0700 [thread overview]
Message-ID: <20131012171345.GB5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131012065326.GG15339@leaf>
On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote:
> On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote:
> > Changes from v2:
> >
> > o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
> > the pointers are all --rcu and already visible to readers,
> > as suggested by Eric Dumazet and Josh Triplett.
>
> Hang on a moment. Do *none* of these cases need write memory barriers?
Sigh. Some afternoons it doesn't pay to touch the keyboard.
Thank you for catching this. I will fix, but at this point, I am thinking
in terms of 3.14 rather than 3.13 for this series.
Thanx, Paul
next prev parent reply other threads:[~2013-10-12 17:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 23:16 [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13 Paul E. McKenney
2013-10-11 23:16 ` Paul E. McKenney
2013-10-11 23:16 ` Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 01/14] rcu: Add comment on evaluate-once properties of rcu_assign_pointer() Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 02/14] notifiers: Apply ACCESS_ONCE() to avoid sparse false positive Paul E. McKenney
2013-10-11 23:17 ` [Bridge] [PATCH v3 tip/core/rcu 03/14] bridge: " Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` [Bridge] [PATCH v3 tip/core/rcu 04/14] wireless: " Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 05/14] decnet: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 06/14] ipv4/ip_socketglue: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 07/14] ipv6/ip6_tunnel: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 08/14] ipv6/ip6_gre: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 09/14] ipv6/sit: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 10/14] mac80211: " Paul E. McKenney
2013-10-11 23:17 ` [Bridge] [PATCH v3 tip/core/rcu 11/14] bridge/br_mdb: " Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` [Bridge] [PATCH v3 tip/core/rcu 12/14] bonding/bond_main: " Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 13/14] bonding/bond_alb.c: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 14/14] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Paul E. McKenney
2013-10-12 6:53 ` [Bridge] [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13 Josh Triplett
2013-10-12 6:53 ` Josh Triplett
2013-10-12 17:13 ` Paul E. McKenney [this message]
2013-10-12 17:13 ` Paul E. McKenney
2013-10-12 17:13 ` Paul E. McKenney
2013-10-12 17:39 ` [Bridge] " Hannes Frederic Sowa
2013-10-12 17:39 ` Hannes Frederic Sowa
2013-10-12 17:43 ` Hannes Frederic Sowa
2013-10-13 11:17 ` Paul E. McKenney
2013-10-13 11:17 ` Paul E. McKenney
2013-10-13 11:15 ` [Bridge] " Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012171345.GB5790@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=darren@dvhart.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jmorris@namei.org \
--cc=johannes@sipsolutions.net \
--cc=josh@joshtriplett.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=laijs@cn.fujitsu.com \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.