* [PATCH] Export percpu-refcount functions
@ 2013-10-11 12:28 Matias Bjorling
2013-10-11 12:28 ` [PATCH] percpu-refcount: Export symbols Matias Bjorling
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjorling @ 2013-10-11 12:28 UTC (permalink / raw)
To: tj, koverstreet, paulmck, tytso; +Cc: linux-kernel, Matias Bjorling
ERROR: "percpu_ref_kill_and_confirm" [...] undefined!
Working on a driver that needs them, but other modules might benefit as well.
Matias Bjorling (1):
percpu-refcount: Export symbols
lib/percpu-refcount.c | 3 +++
1 file changed, 3 insertions(+)
--
1.8.1.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] percpu-refcount: Export symbols
2013-10-11 12:28 [PATCH] Export percpu-refcount functions Matias Bjorling
@ 2013-10-11 12:28 ` Matias Bjorling
2013-10-13 11:09 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjorling @ 2013-10-11 12:28 UTC (permalink / raw)
To: tj, koverstreet, paulmck, tytso; +Cc: linux-kernel, Matias Bjorling
Need to be exported for being used within modules.
Signed-off-by: Matias Bjorling <m@bjorling.me>
---
lib/percpu-refcount.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c
index 7deeb62..25b9ac7 100644
--- a/lib/percpu-refcount.c
+++ b/lib/percpu-refcount.c
@@ -53,6 +53,7 @@ int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release)
ref->release = release;
return 0;
}
+EXPORT_SYMBOL(percpu_ref_init);
/**
* percpu_ref_cancel_init - cancel percpu_ref_init()
@@ -84,6 +85,7 @@ void percpu_ref_cancel_init(struct percpu_ref *ref)
free_percpu(ref->pcpu_count);
}
}
+EXPORT_SYMBOL(percpu_ref_cancel_init);
static void percpu_ref_kill_rcu(struct rcu_head *rcu)
{
@@ -156,3 +158,4 @@ void percpu_ref_kill_and_confirm(struct percpu_ref *ref,
call_rcu_sched(&ref->rcu, percpu_ref_kill_rcu);
}
+EXPORT_SYMBOL(percpu_ref_kill_and_confirm);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] percpu-refcount: Export symbols
2013-10-11 12:28 ` [PATCH] percpu-refcount: Export symbols Matias Bjorling
@ 2013-10-13 11:09 ` Paul E. McKenney
2013-10-13 17:01 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2013-10-13 11:09 UTC (permalink / raw)
To: Matias Bjorling; +Cc: tj, koverstreet, tytso, linux-kernel
On Fri, Oct 11, 2013 at 02:28:12PM +0200, Matias Bjorling wrote:
> Need to be exported for being used within modules.
>
> Signed-off-by: Matias Bjorling <m@bjorling.me>
I will bite... Why not EXPORT_SYMBOL_GPL()?
Thanx, Paul
> ---
> lib/percpu-refcount.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c
> index 7deeb62..25b9ac7 100644
> --- a/lib/percpu-refcount.c
> +++ b/lib/percpu-refcount.c
> @@ -53,6 +53,7 @@ int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release)
> ref->release = release;
> return 0;
> }
> +EXPORT_SYMBOL(percpu_ref_init);
>
> /**
> * percpu_ref_cancel_init - cancel percpu_ref_init()
> @@ -84,6 +85,7 @@ void percpu_ref_cancel_init(struct percpu_ref *ref)
> free_percpu(ref->pcpu_count);
> }
> }
> +EXPORT_SYMBOL(percpu_ref_cancel_init);
>
> static void percpu_ref_kill_rcu(struct rcu_head *rcu)
> {
> @@ -156,3 +158,4 @@ void percpu_ref_kill_and_confirm(struct percpu_ref *ref,
>
> call_rcu_sched(&ref->rcu, percpu_ref_kill_rcu);
> }
> +EXPORT_SYMBOL(percpu_ref_kill_and_confirm);
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] percpu-refcount: Export symbols
2013-10-13 11:09 ` Paul E. McKenney
@ 2013-10-13 17:01 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2013-10-13 17:01 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Matias Bjorling, koverstreet, tytso, linux-kernel
On Sun, Oct 13, 2013 at 04:09:25AM -0700, Paul E. McKenney wrote:
> On Fri, Oct 11, 2013 at 02:28:12PM +0200, Matias Bjorling wrote:
> > Need to be exported for being used within modules.
> >
> > Signed-off-by: Matias Bjorling <m@bjorling.me>
>
> I will bite... Why not EXPORT_SYMBOL_GPL()?
Seconded. Please use EXPORT_SYMBOL_GPL.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-13 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-11 12:28 [PATCH] Export percpu-refcount functions Matias Bjorling
2013-10-11 12:28 ` [PATCH] percpu-refcount: Export symbols Matias Bjorling
2013-10-13 11:09 ` Paul E. McKenney
2013-10-13 17:01 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.