All of lore.kernel.org
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial
Date: Mon, 14 Oct 2013 04:07:10 +0200	[thread overview]
Message-ID: <201310140407.11129.marex@denx.de> (raw)
In-Reply-To: <20131014013119.GB3879@shlinux1.ap.freescale.net>

Dear Peter Chen,

> On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote:
> > Hi,
> > 
> > > After adding IC fixes bits, some PHY bugs are fixed by
> > > IC logic.
> > 
> > Can you please elaborate what those bits do exactly ? They seem like a
> > magic stuff to me thus far, which is not exactly helpful . I can't find
> > them in the datasheet either.
> 
> Yes, these bits are added at late TO verion for i.mx 6, and these TO
> versions will be for mass production, unfortunately, the related doc
> update may be forgotten.
> 
> These two bits are related to two PHY bugs, two PHY bugs are still existed
> at mx28 and mx23, one bug is fixed at mx6dq and mx6dl, and both of two
> bugs are fixed at later mx6 (like mx6sololite and later SoCs), but the IC
> fixes are not enabled by default, it needs software opens it.

Sure, I get it. But what exactly does that bit do? Can you add a proper (and 
likely beefy) comment into the code to supplement the missing parts in the 
datasheet?

Best regards,
Marek Vasut

  reply	other threads:[~2013-10-14  2:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  9:09 [PATCH 00/12] Add power management support for MXS PHY Peter Chen
2013-10-12  9:09 ` [PATCH 01/12] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-10-12  9:09 ` [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial Peter Chen
2013-10-12  9:38   ` Marek Vasut
2013-10-14  1:31     ` Peter Chen
2013-10-14  2:07       ` Marek Vasut [this message]
2013-10-14  1:58         ` Peter Chen
2013-10-14  9:09   ` Shawn Guo
2013-10-14  9:09     ` Peter Chen
2013-10-14  9:29       ` Shawn Guo
2013-10-14  9:16         ` Peter Chen
2013-10-12  9:09 ` [PATCH 03/12] usb: phy-mxs: Add anatop regmap Peter Chen
2013-10-12  9:09 ` [PATCH 04/12] usb: phy: add notify suspend and resume callback Peter Chen
2013-10-12  9:09 ` [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-10-12  9:42   ` Marek Vasut
2013-10-14  1:36     ` Peter Chen
2013-10-14  2:08       ` Marek Vasut
2013-10-12  9:09 ` [PATCH 06/12] usb: phy: Add set_wakeup API Peter Chen
2013-10-12  9:09 ` [PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-10-12  9:44   ` Marek Vasut
2013-10-14  1:41     ` Peter Chen
2013-10-12  9:09 ` [PATCH 08/12] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-10-12  9:09 ` [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-10-14  9:22   ` Shawn Guo
2013-10-14  9:10     ` Peter Chen
2013-10-12  9:09 ` [PATCH 10/12] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-10-12  9:09 ` [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property Peter Chen
2013-10-12  9:47   ` Marek Vasut
2013-10-14  1:44     ` Peter Chen
2013-10-12 15:05   ` Thomas Petazzoni
2013-10-14  1:45     ` Peter Chen
2013-10-12  9:09 ` [PATCH 12/12] ARM: dts: imx6: Add disconnect_line_without_vbus property for usbphy Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310140407.11129.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.