From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial
Date: Mon, 14 Oct 2013 17:09:56 +0800 [thread overview]
Message-ID: <20131014090955.GC26191@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <20131014090953.GC27668@S2101-09.ap.freescale.net>
On Mon, Oct 14, 2013 at 05:09:55PM +0800, Shawn Guo wrote:
> On Sat, Oct 12, 2013 at 05:09:36PM +0800, Peter Chen wrote:
> > After adding IC fixes bits, some PHY bugs are fixed by
> > IC logic.
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > ---
> > drivers/usb/phy/phy-mxs-usb.c | 10 ++++++++++
> > 1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> > index 87ba429..831b13e 100644
> > --- a/drivers/usb/phy/phy-mxs-usb.c
> > +++ b/drivers/usb/phy/phy-mxs-usb.c
> > @@ -29,6 +29,10 @@
> > #define HW_USBPHY_CTRL_SET 0x34
> > #define HW_USBPHY_CTRL_CLR 0x38
> >
> > +#define HW_USBPHY_IP 0x90
> > +#define HW_USBPHY_IP_SET 0x94
> > +#define HW_USBPHY_IP_CLR 0x98
> > +
> > #define BM_USBPHY_CTRL_SFTRST BIT(31)
> > #define BM_USBPHY_CTRL_CLKGATE BIT(30)
> > #define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26)
> > @@ -40,6 +44,8 @@
> > #define BM_USBPHY_CTRL_ENUTMILEVEL2 BIT(14)
> > #define BM_USBPHY_CTRL_ENHOSTDISCONDETECT BIT(1)
> >
> > +#define BM_USBPHY_IP_FIX (BIT(17) | BIT(18))
> > +
> > #define to_mxs_phy(p) container_of((p), struct mxs_phy, phy)
> >
> > enum imx_phy_type {
> > @@ -118,6 +124,10 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
> > BM_USBPHY_CTRL_ENUTMILEVEL3,
> > base + HW_USBPHY_CTRL_SET);
> >
> > + /* Enable IC solution */
> > + if (is_mx6q_phy(mxs_phy) || is_mx6sl_phy(mxs_phy))
>
> Am I missing any dependency/patches here? Where were is_mx6q_phy() and
> is_mx6sl_phy() introduced?
>
> Shawn
>
> > + writel(BM_USBPHY_IP_FIX, base + HW_USBPHY_IP_SET);
> > +
> > return 0;
> > }
> >
> > --
> > 1.7.1
> >
> >
Oh, sorry. I forget to put below one to this serial.
Will do at v2
http://marc.info/?l=linux-usb&m=137871552016298&w=2
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-10-14 9:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 9:09 [PATCH 00/12] Add power management support for MXS PHY Peter Chen
2013-10-12 9:09 ` [PATCH 01/12] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-10-12 9:09 ` [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial Peter Chen
2013-10-12 9:38 ` Marek Vasut
2013-10-14 1:31 ` Peter Chen
2013-10-14 2:07 ` Marek Vasut
2013-10-14 1:58 ` Peter Chen
2013-10-14 9:09 ` Shawn Guo
2013-10-14 9:09 ` Peter Chen [this message]
2013-10-14 9:29 ` Shawn Guo
2013-10-14 9:16 ` Peter Chen
2013-10-12 9:09 ` [PATCH 03/12] usb: phy-mxs: Add anatop regmap Peter Chen
2013-10-12 9:09 ` [PATCH 04/12] usb: phy: add notify suspend and resume callback Peter Chen
2013-10-12 9:09 ` [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-10-12 9:42 ` Marek Vasut
2013-10-14 1:36 ` Peter Chen
2013-10-14 2:08 ` Marek Vasut
2013-10-12 9:09 ` [PATCH 06/12] usb: phy: Add set_wakeup API Peter Chen
2013-10-12 9:09 ` [PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-10-12 9:44 ` Marek Vasut
2013-10-14 1:41 ` Peter Chen
2013-10-12 9:09 ` [PATCH 08/12] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-10-12 9:09 ` [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-10-14 9:22 ` Shawn Guo
2013-10-14 9:10 ` Peter Chen
2013-10-12 9:09 ` [PATCH 10/12] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-10-12 9:09 ` [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property Peter Chen
2013-10-12 9:47 ` Marek Vasut
2013-10-14 1:44 ` Peter Chen
2013-10-12 15:05 ` Thomas Petazzoni
2013-10-14 1:45 ` Peter Chen
2013-10-12 9:09 ` [PATCH 12/12] ARM: dts: imx6: Add disconnect_line_without_vbus property for usbphy Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014090955.GC26191@shlinux1.ap.freescale.net \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.