All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size
Date: Mon, 14 Oct 2013 00:29:43 -0700	[thread overview]
Message-ID: <20131014072943.GA21013@infradead.org> (raw)
In-Reply-To: <20131014045007.GF4446@dastard>

On Mon, Oct 14, 2013 at 03:50:07PM +1100, Dave Chinner wrote:
> I think there should be a bit more cleanup of this lock_flags
> variable. There's quite a few error paths that now "goto out_unlock"
> without actually holding a lock. i.e. they could just become a
> straight "return error", and lock_flags can probably go away
> completely...

I'll look into that.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-14  7:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:55 [PATCH 0/5] refactor the preallocation and hole punching code Christoph Hellwig
2013-10-12  7:55 ` [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size Christoph Hellwig
2013-10-14  4:50   ` Dave Chinner
2013-10-14  7:29     ` Christoph Hellwig [this message]
2013-10-14 14:09   ` [PATCH 1/5 v3] " Christoph Hellwig
2013-10-14 20:28     ` Dave Chinner
2013-10-12  7:55 ` [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag Christoph Hellwig
2013-10-14  4:51   ` Dave Chinner
2013-10-17 20:01     ` Ben Myers
2013-10-17 20:03       ` Christoph Hellwig
2013-10-17 21:17         ` Ben Myers
2013-10-12  7:55 ` [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space Christoph Hellwig
2013-10-14  4:55   ` Dave Chinner
2013-10-12  7:55 ` [PATCH 4/5] xfs: simplify the fallocate path Christoph Hellwig
2013-10-14  5:04   ` Dave Chinner
2013-10-14  7:30     ` Christoph Hellwig
2013-10-14 20:03       ` Dave Chinner
2013-10-12  7:55 ` [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space Christoph Hellwig
2013-10-14  5:08   ` Dave Chinner
2013-10-15 15:31     ` Christoph Hellwig
2013-10-15 21:47       ` Dave Chinner
2013-10-16  7:03         ` Christoph Hellwig
2013-10-21 21:58 ` [PATCH 0/5] refactor the preallocation and hole punching code Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131014072943.GA21013@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.