All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space
Date: Wed, 16 Oct 2013 08:47:33 +1100	[thread overview]
Message-ID: <20131015214733.GW4446@dastard> (raw)
In-Reply-To: <20131015153143.GA1612@infradead.org>

On Tue, Oct 15, 2013 at 08:31:43AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 14, 2013 at 04:08:07PM +1100, Dave Chinner wrote:
> > One question, though:
> > 
> > > +	case XFS_IOC_ALLOCSP:
> > > +	case XFS_IOC_ALLOCSP64:
> > > +	case XFS_IOC_FREESP:
> > > +	case XFS_IOC_FREESP64:
> > 
> > Should we, at this point, mark these ioctls as deprecated and
> > schedule then for removal given that we've recommended against using
> > them for the past 10 years and we have fallocate() now?
> 
> I don't see any reason to remove them given that it's only about 15
> extra lines of code.  But if you care enough to get rid of them we
> probably need multiple years of actuall warnings emmited when used
> before actually removing them.  I would be very surprised if there
> aren't same users that wouldn't argue very vocally against their
> removal.

I'll put a significant quantity of beer on the table if anyone other
than xfstests is actually using these ioctls. In all my years of
working with XFS, I've never seen a single user of them, even on
Irix.

The one person I know who was considering using XFS_IOC_ALLOCSP
convinced me (quite easily) to implement XFS_IOC_ZERO_RANGE for them
because writing all those zeros to re-initialise pre-allocated VM
images was going to be prohibitively expensive...

Anyway, it was just a thought.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-15 21:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:55 [PATCH 0/5] refactor the preallocation and hole punching code Christoph Hellwig
2013-10-12  7:55 ` [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size Christoph Hellwig
2013-10-14  4:50   ` Dave Chinner
2013-10-14  7:29     ` Christoph Hellwig
2013-10-14 14:09   ` [PATCH 1/5 v3] " Christoph Hellwig
2013-10-14 20:28     ` Dave Chinner
2013-10-12  7:55 ` [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag Christoph Hellwig
2013-10-14  4:51   ` Dave Chinner
2013-10-17 20:01     ` Ben Myers
2013-10-17 20:03       ` Christoph Hellwig
2013-10-17 21:17         ` Ben Myers
2013-10-12  7:55 ` [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space Christoph Hellwig
2013-10-14  4:55   ` Dave Chinner
2013-10-12  7:55 ` [PATCH 4/5] xfs: simplify the fallocate path Christoph Hellwig
2013-10-14  5:04   ` Dave Chinner
2013-10-14  7:30     ` Christoph Hellwig
2013-10-14 20:03       ` Dave Chinner
2013-10-12  7:55 ` [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space Christoph Hellwig
2013-10-14  5:08   ` Dave Chinner
2013-10-15 15:31     ` Christoph Hellwig
2013-10-15 21:47       ` Dave Chinner [this message]
2013-10-16  7:03         ` Christoph Hellwig
2013-10-21 21:58 ` [PATCH 0/5] refactor the preallocation and hole punching code Ben Myers
  -- strict thread matches above, loose matches on Subject: below --
2012-12-08 12:08 Christoph Hellwig
2012-12-08 12:08 ` [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131015214733.GW4446@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.