* usb_control_msg and non-dma buffers
@ 2013-10-14 15:47 Guenter Roeck
2013-10-14 15:53 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2013-10-14 15:47 UTC (permalink / raw)
To: linux-usb; +Cc: Greg Kroah-Hartman, linux-watchdog@vger.kernel.org
Hi all,
I am getting the following smatch error in drivers/watchdog/pcwd_usb.c:
drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on the stack (buf)
This is from a call to usb_control_msg().
Is this a false positive or a real problem that needs to be fixed ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: usb_control_msg and non-dma buffers
2013-10-14 15:47 usb_control_msg and non-dma buffers Guenter Roeck
@ 2013-10-14 15:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2013-10-14 15:53 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-usb, linux-watchdog@vger.kernel.org
On Mon, Oct 14, 2013 at 08:47:36AM -0700, Guenter Roeck wrote:
> Hi all,
>
> I am getting the following smatch error in drivers/watchdog/pcwd_usb.c:
>
> drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on the stack (buf)
>
> This is from a call to usb_control_msg().
>
> Is this a false positive or a real problem that needs to be fixed ?
It is a real problem that must be fixed.
You can't send USB data off of the stack and expect the driver to work
on all controllers and platforms.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-14 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-14 15:47 usb_control_msg and non-dma buffers Guenter Roeck
2013-10-14 15:53 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.