From: Shaohua Li <shli@kernel.org>
To: linux-kernel@vger.kernel.org, axboe@kernel.dk
Cc: kmo@daterainc.com
Subject: [patch 2/4 v2] percpu_ida: add percpu_ida_for_each_free
Date: Tue, 15 Oct 2013 09:05:02 +0800 [thread overview]
Message-ID: <20131015010802.638033741@kernel.org> (raw)
In-Reply-To: 20131015010500.435964635@kernel.org
[-- Attachment #1: 0002-percpu_ida-add-percpu_ida_for_each_free.patch --]
[-- Type: text/plain, Size: 2394 bytes --]
Add a new API to iterate free ids. blk-mq-tag will use it.
Note, this doesn't guarantee to iterate all free ids restrictly. Caller should
be aware of this. blk-mq uses it to do sanity check for request timedout, so
can tolerate the limitation.
Signed-off-by: Shaohua Li <shli@fusionio.com>
---
include/linux/percpu_ida.h | 4 ++++
lib/percpu_ida.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 48 insertions(+)
Index: master/include/linux/percpu_ida.h
===================================================================
--- master.orig/include/linux/percpu_ida.h 2013-10-15 08:28:36.198031207 +0800
+++ master/include/linux/percpu_ida.h 2013-10-15 08:30:19.996733244 +0800
@@ -73,4 +73,8 @@ static inline int percpu_ida_init(struct
IDA_DEFAULT_PCPU_BATCH_MOVE);
}
+typedef int (*percpu_ida_cb)(unsigned, void *);
+int percpu_ida_for_each_free(struct percpu_ida *pool, percpu_ida_cb fn,
+ void *data);
+
#endif /* __PERCPU_IDA_H__ */
Index: master/lib/percpu_ida.c
===================================================================
--- master.orig/lib/percpu_ida.c 2013-10-15 08:28:36.198031207 +0800
+++ master/lib/percpu_ida.c 2013-10-15 08:40:06.937353699 +0800
@@ -327,3 +327,47 @@ err:
return -ENOMEM;
}
EXPORT_SYMBOL_GPL(__percpu_ida_init);
+
+/**
+ * percpu_ida_for_each_free - iterate free ids of a pool
+ * @pool: pool to iterate
+ * @fn: interate callback function
+ * @data: parameter for @fn
+ *
+ * Note, this doesn't guarantee to iterate all free ids restrictly. Some free
+ * ids might be missed, some might be iterated duplicated, and some might
+ * be iterated and not free soon.
+ */
+int percpu_ida_for_each_free(struct percpu_ida *pool, percpu_ida_cb fn,
+ void *data)
+{
+ unsigned long flags;
+ struct percpu_ida_cpu *remote;
+ unsigned cpu, i, err = 0;
+
+ local_irq_save(flags);
+ for_each_possible_cpu(cpu) {
+ remote = per_cpu_ptr(pool->tag_cpu, cpu);
+ spin_lock(&remote->lock);
+ for (i = 0; i < remote->nr_free; i++) {
+ err = fn(remote->freelist[i], data);
+ if (err)
+ break;
+ }
+ spin_unlock(&remote->lock);
+ if (err)
+ goto out;
+ }
+
+ spin_lock(&pool->lock);
+ for (i = 0; i < pool->nr_free; i++) {
+ err = fn(pool->freelist[i], data);
+ if (err)
+ break;
+ }
+ spin_unlock(&pool->lock);
+out:
+ local_irq_restore(flags);
+ return err;
+}
+EXPORT_SYMBOL_GPL(percpu_ida_for_each_free);
next prev parent reply other threads:[~2013-10-15 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 1:05 [patch 0/4 v2] blk-mq: use percpu_ida to manage tags Shaohua Li
2013-10-15 1:05 ` [patch 1/4 v2] percpu_ida: make percpu_ida percpu size/batch configurable Shaohua Li
2013-10-15 1:05 ` Shaohua Li [this message]
2013-10-15 1:05 ` [patch 3/4 v2] percpu_ida: add an API to return free tags Shaohua Li
2013-10-15 1:05 ` [patch 4/4 v2] blk-mq: switch to percpu-ida for tag management Shaohua Li
2013-10-15 15:16 ` [patch 0/4 v2] blk-mq: use percpu_ida to manage tags Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015010802.638033741@kernel.org \
--to=shli@kernel.org \
--cc=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.