From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org, kmo@daterainc.com
Subject: Re: [patch 0/4 v2] blk-mq: use percpu_ida to manage tags
Date: Tue, 15 Oct 2013 09:16:31 -0600 [thread overview]
Message-ID: <20131015151631.GK541@kernel.dk> (raw)
In-Reply-To: <20131015010500.435964635@kernel.org>
On Tue, Oct 15 2013, Shaohua Li wrote:
> Hi,
> blk-mq and percpu_ida use similar algorithm to manage tags. The difference
> is when a cpu can't allocate tags, blk-mq will use ipi to purge remote cpu
> cache, while percpu-ida directly purges remote cpu cache. In practice, the
> percpu-ida approach is much faster when we can't allocate enough for percpu
> cache.
>
> This patch makes blk-mq use percpu_ida to manage tags, this avoids some
> duplicate code and has better performance as I mentioned. To test the patches,
> rebase blk-mq tree to latest kernel first.
>
> The v2 patch updated some log descriptions, fixed one issue Kent pointed out
> and added performance data.
Thanks, I've rebased it to 3.12-rc5 and applied the series.
--
Jens Axboe
prev parent reply other threads:[~2013-10-15 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 1:05 [patch 0/4 v2] blk-mq: use percpu_ida to manage tags Shaohua Li
2013-10-15 1:05 ` [patch 1/4 v2] percpu_ida: make percpu_ida percpu size/batch configurable Shaohua Li
2013-10-15 1:05 ` [patch 2/4 v2] percpu_ida: add percpu_ida_for_each_free Shaohua Li
2013-10-15 1:05 ` [patch 3/4 v2] percpu_ida: add an API to return free tags Shaohua Li
2013-10-15 1:05 ` [patch 4/4 v2] blk-mq: switch to percpu-ida for tag management Shaohua Li
2013-10-15 15:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015151631.GK541@kernel.dk \
--to=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.