From: Vinod Koul <vinod.koul@intel.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH RESEND 2/3] dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
Date: Wed, 16 Oct 2013 07:34:45 +0530 [thread overview]
Message-ID: <20131016020445.GS2954@intel.com> (raw)
In-Reply-To: <201310111101.04721.heiko@sntech.de>
On Fri, Oct 11, 2013 at 11:01:04AM +0200, Heiko Stübner wrote:
> The earliest variants of the dma controller did not contain support for
> controlling clocks.
Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/dma/s3c24xx-dma.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 56c9253..4cb1279 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -1078,6 +1078,13 @@ static void s3c24xx_dma_free_virtual_channels(struct dma_device *dmadev)
> list_del(&chan->vc.chan.device_node);
> }
>
> +/* s3c2410, s3c2440 and s3c2442 have a 0x40 stride without separate clocks */
> +static struct soc_data soc_s3c2410 = {
> + .stride = 0x40,
> + .has_reqsel = false,
> + .has_clocks = false,
> +};
> +
> /* s3c2412 and s3c2413 have a 0x40 stride and dmareqsel mechanism */
> static struct soc_data soc_s3c2412 = {
> .stride = 0x40,
> @@ -1094,6 +1101,9 @@ static struct soc_data soc_s3c2443 = {
>
> static struct platform_device_id s3c24xx_dma_driver_ids[] = {
> {
> + .name = "s3c2410-dma",
> + .driver_data = (kernel_ulong_t)&soc_s3c2410,
> + }, {
> .name = "s3c2412-dma",
> .driver_data = (kernel_ulong_t)&soc_s3c2412,
> }, {
> --
> 1.7.10.4
>
--
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 2/3] dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
Date: Wed, 16 Oct 2013 07:34:45 +0530 [thread overview]
Message-ID: <20131016020445.GS2954@intel.com> (raw)
In-Reply-To: <201310111101.04721.heiko@sntech.de>
On Fri, Oct 11, 2013 at 11:01:04AM +0200, Heiko St?bner wrote:
> The earliest variants of the dma controller did not contain support for
> controlling clocks.
Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/dma/s3c24xx-dma.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 56c9253..4cb1279 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -1078,6 +1078,13 @@ static void s3c24xx_dma_free_virtual_channels(struct dma_device *dmadev)
> list_del(&chan->vc.chan.device_node);
> }
>
> +/* s3c2410, s3c2440 and s3c2442 have a 0x40 stride without separate clocks */
> +static struct soc_data soc_s3c2410 = {
> + .stride = 0x40,
> + .has_reqsel = false,
> + .has_clocks = false,
> +};
> +
> /* s3c2412 and s3c2413 have a 0x40 stride and dmareqsel mechanism */
> static struct soc_data soc_s3c2412 = {
> .stride = 0x40,
> @@ -1094,6 +1101,9 @@ static struct soc_data soc_s3c2443 = {
>
> static struct platform_device_id s3c24xx_dma_driver_ids[] = {
> {
> + .name = "s3c2410-dma",
> + .driver_data = (kernel_ulong_t)&soc_s3c2410,
> + }, {
> .name = "s3c2412-dma",
> .driver_data = (kernel_ulong_t)&soc_s3c2412,
> }, {
> --
> 1.7.10.4
>
--
next prev parent reply other threads:[~2013-10-16 2:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 8:59 [PATCH RESEND 0/3] ARM: S3C24XX: add missing dma-devices and warning fix Heiko Stübner
2013-10-11 8:59 ` Heiko Stübner
2013-10-11 9:00 ` [PATCH RESEND 1/3] ARM: S3C24XX: Fix possible dma selection warning Heiko Stübner
2013-10-11 9:00 ` Heiko Stübner
2013-10-11 9:01 ` [PATCH RESEND 2/3] dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller Heiko Stübner
2013-10-11 9:01 ` Heiko Stübner
2013-10-16 2:04 ` Vinod Koul [this message]
2013-10-16 2:04 ` Vinod Koul
2013-10-11 9:01 ` [PATCH RESEND 3/3] ARM: S3C24XX: add dma pdata for s3c2410, s3c2440 and s3c2442 Heiko Stübner
2013-10-11 9:01 ` Heiko Stübner
2013-10-13 14:55 ` Vinod Koul
2013-10-13 14:55 ` Vinod Koul
2013-10-13 18:15 ` Heiko Stübner
2013-10-13 18:15 ` Heiko Stübner
2013-10-12 4:38 ` [PATCH RESEND 0/3] ARM: S3C24XX: add missing dma-devices and warning fix Tomasz Figa
2013-10-12 4:38 ` Tomasz Figa
[not found] ` <15184009.9QsSDOGPSA@amdn883>
2013-10-12 12:33 ` Mark Brown
2013-10-12 12:33 ` Mark Brown
2013-10-13 18:29 ` Tomasz Figa
2013-10-13 18:29 ` Tomasz Figa
2013-10-14 14:19 ` Mark Brown
2013-10-14 14:19 ` Mark Brown
2013-10-13 14:56 ` Vinod Koul
2013-10-13 14:56 ` Vinod Koul
2013-10-13 18:11 ` Heiko Stübner
2013-10-13 18:11 ` Heiko Stübner
2013-10-15 22:32 ` Kukjin Kim
2013-10-15 22:32 ` Kukjin Kim
2013-10-16 2:05 ` Vinod Koul
2013-10-16 2:05 ` Vinod Koul
2013-10-20 20:27 ` Kukjin Kim
2013-10-20 20:27 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016020445.GS2954@intel.com \
--to=vinod.koul@intel.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.