From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
xfs@oss.sgi.com
Subject: Re: fs/attr.c:notify_change locking warning.
Date: Wed, 16 Oct 2013 11:12:34 -0700 [thread overview]
Message-ID: <20131016181234.GA26646@infradead.org> (raw)
In-Reply-To: <20131016102651.GF4446@dastard>
On Wed, Oct 16, 2013 at 09:26:51PM +1100, Dave Chinner wrote:
> The killpriv calls? I couldn't find anything that implemented those
> security hooks nor any documentation about it, so I'm pretty much
> clueless about it. FWIW, ocfs2 doesn't implement them, either....
The killpriv code ends up doing xattr calls for per-file capabilities
(grep security/commoncap.c for killpriv). Seems like ocfs2 is buggy in
that regard.
I suspect the easiest way to solve it properly in XFS is to simply
retake the iolock exclusive and get the i_mutex as part of it. This
means direct I/O writes to files with the suid bit won't scale, but I
think we can live with that given that it avoids introducing special
cases that impact more code.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Jones <davej@redhat.com>,
xfs@oss.sgi.com, Linux Kernel <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: fs/attr.c:notify_change locking warning.
Date: Wed, 16 Oct 2013 11:12:34 -0700 [thread overview]
Message-ID: <20131016181234.GA26646@infradead.org> (raw)
In-Reply-To: <20131016102651.GF4446@dastard>
On Wed, Oct 16, 2013 at 09:26:51PM +1100, Dave Chinner wrote:
> The killpriv calls? I couldn't find anything that implemented those
> security hooks nor any documentation about it, so I'm pretty much
> clueless about it. FWIW, ocfs2 doesn't implement them, either....
The killpriv code ends up doing xattr calls for per-file capabilities
(grep security/commoncap.c for killpriv). Seems like ocfs2 is buggy in
that regard.
I suspect the easiest way to solve it properly in XFS is to simply
retake the iolock exclusive and get the i_mutex as part of it. This
means direct I/O writes to files with the suid bit won't scale, but I
think we can live with that given that it avoids introducing special
cases that impact more code.
next prev parent reply other threads:[~2013-10-16 18:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 0:52 fs/attr.c:notify_change locking warning Dave Jones
2013-10-05 0:52 ` Dave Jones
2013-10-05 3:19 ` Dave Chinner
2013-10-05 3:19 ` Dave Chinner
2013-10-15 20:19 ` Christoph Hellwig
2013-10-15 20:19 ` Christoph Hellwig
2013-10-15 21:36 ` Dave Chinner
2013-10-15 21:36 ` Dave Chinner
2013-10-16 7:05 ` Christoph Hellwig
2013-10-16 7:05 ` Christoph Hellwig
2013-10-16 10:26 ` Dave Chinner
2013-10-16 10:26 ` Dave Chinner
2013-10-16 18:12 ` Christoph Hellwig [this message]
2013-10-16 18:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016181234.GA26646@infradead.org \
--to=hch@infradead.org \
--cc=davej@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.