* [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks
@ 2013-10-16 18:51 Dhanunjaya
2013-10-16 18:51 ` [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon Dhanunjaya
2013-10-16 19:12 ` [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Dhanunjaya @ 2013-10-16 18:51 UTC (permalink / raw)
To: arnaud.patard, gregkh, aaro.koskinen, peterhuewe
Cc: devel, linux-kernel, Dhanunjaya
This is a patch to the vb_setmode.c file that fixes braces {}
are not necessary for single statement blocks warning found
by the checkpatch.pl tool
Signed-of-by: Dhanunjaya <dhanunjaya.matrix@gmail.com>
---
drivers/staging/xgifb/vb_setmode.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 46dea3f..400c726 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -845,11 +845,10 @@ static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
if (pVBInfo->SetFlag & TVSimuMode) {
- if (modeflag & Charx8Dot) {
+ if (modeflag & Charx8Dot)
VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
- } else {
+ else
VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
- }
}
/* 301lv */
@@ -5274,9 +5273,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
outb(0x00, pVBInfo->P3c8);
- for (i = 0; i < 256 * 3; i++) {
+ for (i = 0; i < 256 * 3; i++)
outb(0x0F, (pVBInfo->P3c8 + 1)); /* DAC_TEST_PARMS */
- }
mdelay(1);
@@ -5291,9 +5289,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
/* avoid display something, set BLACK DAC if not restore DAC */
outb(0x00, pVBInfo->P3c8);
- for (i = 0; i < 256 * 3; i++) {
+ for (i = 0; i < 256 * 3; i++)
outb(0, (pVBInfo->P3c8 + 1));
- }
xgifb_reg_set(pVBInfo->P3c4, 0x01, SR01);
xgifb_reg_set(pVBInfo->P3d4, 0x63, CR63);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon.
2013-10-16 18:51 [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks Dhanunjaya
@ 2013-10-16 18:51 ` Dhanunjaya
2013-10-16 19:37 ` Dan Carpenter
2013-10-16 19:12 ` [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Dhanunjaya @ 2013-10-16 18:51 UTC (permalink / raw)
To: arnaud.patard, gregkh, aaro.koskinen, peterhuewe
Cc: devel, linux-kernel, Dhanunjaya
This is a patch to the vb_table.h file that fixes the
space prohibited before semicolon warning found by the
checkpatch.pl tool.
Signed-off-by: Dhanunjaya <dhanunjaya.matrix@gmail.com>
---
drivers/staging/xgifb/vb_table.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_table.h
index 7168eed..f17e5b9 100644
--- a/drivers/staging/xgifb/vb_table.h
+++ b/drivers/staging/xgifb/vb_table.h
@@ -1284,7 +1284,7 @@ static const struct SiS_LVDSData XGI_LVDS1024x768Des_1[] = {
{0, 1048, 0, 771}, /* 04 (640x480x60Hz) */
{0, 1048, 0, 771}, /* 05 (800x600x60Hz) */
{0, 1048, 805, 770} /* 06 (1024x768x60Hz) */
-} ;
+};
static const struct SiS_LVDSData XGI_LVDS1024x768Des_2[] = {
{1142, 856, 622, 587}, /* 00 (320x200,320x400,640x200,640x400) */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon.
2013-10-16 18:51 ` [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon Dhanunjaya
@ 2013-10-16 19:37 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-10-16 19:37 UTC (permalink / raw)
To: Dhanunjaya
Cc: arnaud.patard, gregkh, aaro.koskinen, peterhuewe, devel,
linux-kernel
On Thu, Oct 17, 2013 at 12:21:34AM +0530, Dhanunjaya wrote:
> This is a patch to the vb_table.h file that fixes the
> space prohibited before semicolon warning found by the
> checkpatch.pl tool.
>
Someone already fixed this one.
Btw, for people who aren't aware, linux-next has moved to
git://gitorious.org/thierryreding/linux-next.git until later this month.
Thierry Reding has taken over while Stephen is on vacation.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks
2013-10-16 18:51 [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks Dhanunjaya
2013-10-16 18:51 ` [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon Dhanunjaya
@ 2013-10-16 19:12 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2013-10-16 19:12 UTC (permalink / raw)
To: Dhanunjaya; +Cc: arnaud.patard, aaro.koskinen, peterhuewe, devel, linux-kernel
Where are patches 1/4 and 2/4 in this series?
On Thu, Oct 17, 2013 at 12:21:33AM +0530, Dhanunjaya wrote:
> This is a patch to the vb_setmode.c file that fixes braces {}
> are not necessary for single statement blocks warning found
> by the checkpatch.pl tool
>
> Signed-of-by: Dhanunjaya <dhanunjaya.matrix@gmail.com>
Again, I need a full name before I can take any of these patches.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks
@ 2013-10-16 19:21 Dhanunjaya Naidu Ravada
2013-10-16 19:21 ` [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon Dhanunjaya Naidu Ravada
0 siblings, 1 reply; 5+ messages in thread
From: Dhanunjaya Naidu Ravada @ 2013-10-16 19:21 UTC (permalink / raw)
To: arnaud.patard, gregkh, aaro.koskinen, peterhuewe
Cc: devel, linux-kernel, Dhanunjaya
From: Dhanunjaya <dhanunjaya.matrix@gmail.com>
This is a patch to the vb_setmode.c file that fixes braces {}
are not necessary for single statement blocks warning found
by the checkpatch.pl tool
Signed-of-by: Dhanunjaya Naidu Ravada <dhanunjaya.matrix@gmail.com>
---
drivers/staging/xgifb/vb_setmode.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 46dea3f..400c726 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -845,11 +845,10 @@ static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
if (pVBInfo->SetFlag & TVSimuMode) {
- if (modeflag & Charx8Dot) {
+ if (modeflag & Charx8Dot)
VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
- } else {
+ else
VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
- }
}
/* 301lv */
@@ -5274,9 +5273,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
outb(0x00, pVBInfo->P3c8);
- for (i = 0; i < 256 * 3; i++) {
+ for (i = 0; i < 256 * 3; i++)
outb(0x0F, (pVBInfo->P3c8 + 1)); /* DAC_TEST_PARMS */
- }
mdelay(1);
@@ -5291,9 +5289,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
/* avoid display something, set BLACK DAC if not restore DAC */
outb(0x00, pVBInfo->P3c8);
- for (i = 0; i < 256 * 3; i++) {
+ for (i = 0; i < 256 * 3; i++)
outb(0, (pVBInfo->P3c8 + 1));
- }
xgifb_reg_set(pVBInfo->P3c4, 0x01, SR01);
xgifb_reg_set(pVBInfo->P3d4, 0x63, CR63);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon.
2013-10-16 19:21 Dhanunjaya Naidu Ravada
@ 2013-10-16 19:21 ` Dhanunjaya Naidu Ravada
0 siblings, 0 replies; 5+ messages in thread
From: Dhanunjaya Naidu Ravada @ 2013-10-16 19:21 UTC (permalink / raw)
To: arnaud.patard, gregkh, aaro.koskinen, peterhuewe
Cc: devel, linux-kernel, Dhanunjaya
From: Dhanunjaya <dhanunjaya.matrix@gmail.com>
This is a patch to the vb_table.h file that fixes the
space prohibited before semicolon warning found by the
checkpatch.pl tool.
Signed-off-by: Dhanunjaya Naidu Ravada <dhanunjaya.matrix@gmail.com>
---
drivers/staging/xgifb/vb_table.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_table.h
index 7168eed..f17e5b9 100644
--- a/drivers/staging/xgifb/vb_table.h
+++ b/drivers/staging/xgifb/vb_table.h
@@ -1284,7 +1284,7 @@ static const struct SiS_LVDSData XGI_LVDS1024x768Des_1[] = {
{0, 1048, 0, 771}, /* 04 (640x480x60Hz) */
{0, 1048, 0, 771}, /* 05 (800x600x60Hz) */
{0, 1048, 805, 770} /* 06 (1024x768x60Hz) */
-} ;
+};
static const struct SiS_LVDSData XGI_LVDS1024x768Des_2[] = {
{1142, 856, 622, 587}, /* 00 (320x200,320x400,640x200,640x400) */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-16 19:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-16 18:51 [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks Dhanunjaya
2013-10-16 18:51 ` [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon Dhanunjaya
2013-10-16 19:37 ` Dan Carpenter
2013-10-16 19:12 ` [PATCH 3/4] Staging: xgifb: fix braces {} are not necessary for single statement blocks Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-10-16 19:21 Dhanunjaya Naidu Ravada
2013-10-16 19:21 ` [PATCH 4/4] Staging: xgifb: fix space prohibited before semicolon Dhanunjaya Naidu Ravada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.