From: Gleb Natapov <gleb@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH] kvm-unittest: fix build with gcc 4.3.X and older
Date: Thu, 17 Oct 2013 12:43:15 +0300 [thread overview]
Message-ID: <20131017094315.GQ15657@redhat.com> (raw)
In-Reply-To: <20131017094446.GC14648@redhat.com>
On Thu, Oct 17, 2013 at 12:44:46PM +0300, Michael S. Tsirkin wrote:
> On Thu, Oct 17, 2013 at 12:33:39PM +0300, Gleb Natapov wrote:
> > > > It just papers over the problem. Compiler should either complain that it
> > > > does not know what %w0 or complain that variable length does not match
> > > > assembly
> > >
> > > Of course it can't. Compiler does not parse assembly at all:
> > > these are just constant strings as far as it's concerned.
> > >
> > Compiler does not pars assembly itself but it parses things like %w0 to
> > know what assembly to emit. That is why it complained about %d0 in the
> > first place.
>
> Right. I meant that with this: "outl %0" it has no chance to figure out
> that outl needs eax. It has to go by variable type.
Yes.
--
Gleb.
WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older
Date: Thu, 17 Oct 2013 12:43:15 +0300 [thread overview]
Message-ID: <20131017094315.GQ15657@redhat.com> (raw)
In-Reply-To: <20131017094446.GC14648@redhat.com>
On Thu, Oct 17, 2013 at 12:44:46PM +0300, Michael S. Tsirkin wrote:
> On Thu, Oct 17, 2013 at 12:33:39PM +0300, Gleb Natapov wrote:
> > > > It just papers over the problem. Compiler should either complain that it
> > > > does not know what %w0 or complain that variable length does not match
> > > > assembly
> > >
> > > Of course it can't. Compiler does not parse assembly at all:
> > > these are just constant strings as far as it's concerned.
> > >
> > Compiler does not pars assembly itself but it parses things like %w0 to
> > know what assembly to emit. That is why it complained about %d0 in the
> > first place.
>
> Right. I meant that with this: "outl %0" it has no chance to figure out
> that outl needs eax. It has to go by variable type.
Yes.
--
Gleb.
next prev parent reply other threads:[~2013-10-17 9:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 19:46 [PATCH] kvm-unittest: fix build with gcc 4.3.X and older Michael S. Tsirkin
2013-10-16 19:46 ` [Qemu-devel] " Michael S. Tsirkin
2013-10-17 6:27 ` Gleb Natapov
2013-10-17 6:27 ` [Qemu-devel] " Gleb Natapov
2013-10-17 8:12 ` Michael S. Tsirkin
2013-10-17 8:12 ` [Qemu-devel] " Michael S. Tsirkin
2013-10-17 8:20 ` Gleb Natapov
2013-10-17 8:20 ` [Qemu-devel] " Gleb Natapov
2013-10-17 8:27 ` Michael S. Tsirkin
2013-10-17 8:27 ` [Qemu-devel] " Michael S. Tsirkin
2013-10-17 8:34 ` Gleb Natapov
2013-10-17 8:34 ` [Qemu-devel] " Gleb Natapov
2013-10-17 9:28 ` Michael S. Tsirkin
2013-10-17 9:28 ` [Qemu-devel] " Michael S. Tsirkin
2013-10-17 9:33 ` Gleb Natapov
2013-10-17 9:33 ` [Qemu-devel] " Gleb Natapov
2013-10-17 9:44 ` Michael S. Tsirkin
2013-10-17 9:44 ` [Qemu-devel] " Michael S. Tsirkin
2013-10-17 9:43 ` Gleb Natapov [this message]
2013-10-17 9:43 ` Gleb Natapov
2013-10-17 10:55 ` Paolo Bonzini
2013-10-17 10:55 ` [Qemu-devel] " Paolo Bonzini
2013-10-17 10:58 ` Gleb Natapov
2013-10-17 10:58 ` [Qemu-devel] " Gleb Natapov
2013-10-17 11:02 ` Paolo Bonzini
2013-10-17 11:02 ` [Qemu-devel] " Paolo Bonzini
2013-10-17 11:31 ` Michael S. Tsirkin
2013-10-17 11:31 ` [Qemu-devel] " Michael S. Tsirkin
2013-10-17 10:53 ` Paolo Bonzini
2013-10-17 10:53 ` [Qemu-devel] " Paolo Bonzini
2013-10-17 11:29 ` Michael S. Tsirkin
2013-10-17 11:29 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017094315.GQ15657@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.