From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andi Kleen <ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Seiji Aguchi <seiji.aguchi-7rDLJAbr9SE@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 5/5] efi: Capsule update support and pstore backend
Date: Thu, 17 Oct 2013 12:55:14 +0100 [thread overview]
Message-ID: <20131017115514.GE10834@console-pimps.org> (raw)
In-Reply-To: <20131016141939.GA28684-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
On Wed, 16 Oct, at 03:19:39PM, Matthew Garrett wrote:
> On Wed, Oct 16, 2013 at 02:51:00PM +0100, Matt Fleming wrote:
>
> > + Many EFI machines have buggy implementations of the UpdateCapsule()
> > + runtime service. This option will enable code that may not function
> > + correctly with your firmware.
>
> Where by "May not function correctly" you mean "May crash the system"?
Bingo.
> I'm a little uneasy having this run by default if enabled, even if it's
> disabled by default in the config.
What would be the canonical way to enable this feature then? Have a file
along the lines of /sys/kernel/debug/capsule_enable, where a user would
be required to,
echo 1 > /sys/kernel/debug/capsule_enable
to turn on the functionality?
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>, Tony Luck <tony.luck@intel.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 5/5] efi: Capsule update support and pstore backend
Date: Thu, 17 Oct 2013 12:55:14 +0100 [thread overview]
Message-ID: <20131017115514.GE10834@console-pimps.org> (raw)
In-Reply-To: <20131016141939.GA28684@srcf.ucam.org>
On Wed, 16 Oct, at 03:19:39PM, Matthew Garrett wrote:
> On Wed, Oct 16, 2013 at 02:51:00PM +0100, Matt Fleming wrote:
>
> > + Many EFI machines have buggy implementations of the UpdateCapsule()
> > + runtime service. This option will enable code that may not function
> > + correctly with your firmware.
>
> Where by "May not function correctly" you mean "May crash the system"?
Bingo.
> I'm a little uneasy having this run by default if enabled, even if it's
> disabled by default in the config.
What would be the canonical way to enable this feature then? Have a file
along the lines of /sys/kernel/debug/capsule_enable, where a user would
be required to,
echo 1 > /sys/kernel/debug/capsule_enable
to turn on the functionality?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-17 11:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 13:50 [PATCH 0/5] EFI capsule pstore support Matt Fleming
[not found] ` <1381931460-6999-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-16 13:50 ` [PATCH 1/5] pstore/ftrace: Don't increment initial data offset Matt Fleming
2013-10-16 13:50 ` Matt Fleming
2013-10-16 13:50 ` [PATCH 2/5] efi: Introduce a Runtime Services lock Matt Fleming
[not found] ` <1381931460-6999-3-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-16 23:36 ` Seiji Aguchi
2013-10-16 23:36 ` Seiji Aguchi
2013-10-16 13:50 ` [PATCH 3/5] efi: Add common efi_reboot() implementation Matt Fleming
2013-10-16 13:50 ` [PATCH 4/5] efi: Move efi_status_to_err() to efi.h Matt Fleming
2013-10-16 13:51 ` [PATCH 5/5] efi: Capsule update support and pstore backend Matt Fleming
[not found] ` <1381931460-6999-6-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-16 14:19 ` Matthew Garrett
2013-10-16 14:19 ` Matthew Garrett
[not found] ` <20131016141939.GA28684-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2013-10-16 14:52 ` Luck, Tony
2013-10-16 14:52 ` Luck, Tony
[not found] ` <3908561D78D1C84285E8C5FCA982C28F31D31122-P5GAC/sN6hlZtRGVdHMbwrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-10-17 0:06 ` Seiji Aguchi
2013-10-17 0:06 ` Seiji Aguchi
[not found] ` <A5ED84D3BB3A384992CBB9C77DEDA4D443EF862E-ohthHghroY0jroPwUH3sq+6wyyQG6/Uh@public.gmane.org>
2013-10-17 23:18 ` Andi Kleen
2013-10-17 23:18 ` Andi Kleen
2013-10-17 12:05 ` Matt Fleming
2013-10-17 12:05 ` Matt Fleming
2013-10-17 11:55 ` Matt Fleming [this message]
2013-10-17 11:55 ` Matt Fleming
[not found] ` <20131017115514.GE10834-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-17 23:19 ` Andi Kleen
2013-10-17 23:19 ` Andi Kleen
2013-10-16 20:14 ` Andi Kleen
2013-10-16 20:14 ` Andi Kleen
2013-10-17 12:14 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017115514.GE10834@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=seiji.aguchi-7rDLJAbr9SE@public.gmane.org \
--cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.