All of lore.kernel.org
 help / color / mirror / Atom feed
* [Powertop] [PATCH -next] intel cpus: add proper C-states init
@ 2013-10-17 20:37 Sergey Senozhatsky
  0 siblings, 0 replies; 2+ messages in thread
From: Sergey Senozhatsky @ 2013-10-17 20:37 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

add missing has_c2c7_res init to nhm_core() .ctor and
has_c8c9c10_res/has_c2c7_res init to nhm_package() .ctor.

uninitialised has_c2c7_res/has_c8c9c10_res/has_c2c7_res
may be used in core/package measurement_start()/measurement_end().

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>

---

src/cpu/intel_cpus.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/cpu/intel_cpus.cpp b/src/cpu/intel_cpus.cpp
index 194dc75..ad80337 100644
--- a/src/cpu/intel_cpus.cpp
+++ b/src/cpu/intel_cpus.cpp
@@ -87,6 +87,8 @@ static uint64_t get_msr(int cpu, uint64_t offset)
 
 nhm_core::nhm_core(int model)
 {
+	has_c2c7_res = 0;
+
 	switch(model) {
 		case 0x2A:	/* SNB */
 		case 0x2D:	/* SNB Xeon */
@@ -252,6 +254,9 @@ char * nhm_core::fill_pstate_line(int line_nr, char *buffer)
 
 nhm_package::nhm_package(int model)
 {
+	has_c8c9c10_res = 0;
+	has_c2c7_res = 0;
+
 	switch(model) {
 		case 0x2A:	/* SNB */
 		case 0x2D:	/* SNB Xeon */
@@ -269,7 +274,6 @@ nhm_package::nhm_package(int model)
 	else
 		has_c3_res = 1;
 
-
 	/* Haswell-ULT has C8/9/10*/
 	if (model == 0x45)
 		has_c8c9c10_res = 1;


^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Powertop] [PATCH -next] intel cpus: add proper C-states init
@ 2013-10-18 18:07 Kristen Carlson Accardi
  0 siblings, 0 replies; 2+ messages in thread
From: Kristen Carlson Accardi @ 2013-10-18 18:07 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

On Thu, 17 Oct 2013 23:37:51 +0300
Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> wrote:

> add missing has_c2c7_res init to nhm_core() .ctor and
> has_c8c9c10_res/has_c2c7_res init to nhm_package() .ctor.
> 
> uninitialised has_c2c7_res/has_c8c9c10_res/has_c2c7_res
> may be used in core/package measurement_start()/measurement_end().
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-18 18:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 20:37 [Powertop] [PATCH -next] intel cpus: add proper C-states init Sergey Senozhatsky
  -- strict thread matches above, loose matches on Subject: below --
2013-10-18 18:07 Kristen Carlson Accardi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.