From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set
Date: Fri, 18 Oct 2013 10:44:41 +0300 [thread overview]
Message-ID: <20131018074441.GN13047@intel.com> (raw)
In-Reply-To: <1382078196-4234-1-git-send-email-daniel.vetter@ffwll.ch>
On Fri, Oct 18, 2013 at 08:36:36AM +0200, Daniel Vetter wrote:
> In
>
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Jun 5 13:34:23 2013 +0200
>
> drm/i915: consolidate pch pll enable sequence
>
> I've removed all the code from this if block, but somehow forgotten to
> kill the block itself.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 04c3e1b..38892db 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6072,11 +6072,6 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
> else
> intel_crtc->lowfreq_avail = false;
>
> - if (intel_crtc->config.has_pch_encoder) {
> - pll = intel_crtc_to_shared_dpll(intel_crtc);
> -
> - }
> -
> intel_set_pipe_timings(intel_crtc);
>
> if (intel_crtc->config.has_pch_encoder) {
> --
> 1.8.4.rc3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-10-18 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 6:36 [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set Daniel Vetter
2013-10-18 7:44 ` Ville Syrjälä [this message]
2013-10-18 13:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018074441.GN13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.